Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make dist should generate the MANIFEST #68

Open
atoomic opened this issue May 15, 2019 · 1 comment
Open

make dist should generate the MANIFEST #68

atoomic opened this issue May 15, 2019 · 1 comment

Comments

@atoomic
Copy link
Member

atoomic commented May 15, 2019

@karenetheridge recently removed the MANIFEST from the git repo which is a good idea and avoid discrepancies when performing a release

but we should add the manifest dependency to dist using MY::dist_core

make dist
rm -rf Devel-PPPort-3.51
"/usr/local/perl/perls/perl-5.26.1/bin/perl" "-MExtUtils::Manifest=manicopy,maniread" \
		-e "manicopy(maniread(),'Devel-PPPort-3.51', 'best');"
Problem opening MANIFEST: No such file or directory at /usr/local/perl/perls/perl-5.26.1/lib/5.26.1/ExtUtils/Manifest.pm line 349.
mkdir Devel-PPPort-3.51
Generating META.yml
Generating META.json
Could not add META.yml to MANIFEST: Could not open MANIFEST: No such file or directory at /usr/local/perl/perls/perl-5.26.1/lib/5.26.1/ExtUtils/Manifest.pm line 723.
make: *** [distmeta] Error 2
@atoomic
Copy link
Member Author

atoomic commented May 17, 2019

Steps to reproduce

rm -f MANIFEST; make clean; perl Makefile.PL; make dist
Makefile out-of-date with respect to Makefile.PL
Cleaning current config before rebuilding Makefile...
make -f Makefile.old clean > /dev/null 2>&1
"/usr/local/perl/perls/perl-5.26.2/bin/perl" Makefile.PL
Setting license tag...
Generating a Unix-style Makefile
Writing Makefile for Devel::PPPort
Writing MYMETA.yml and MYMETA.json
==> Your Makefile has been rebuilt. <==
==> Please rerun the make command.  <==
false
make: *** [Makefile] Error 1
Setting license tag...
Generating a Unix-style Makefile
Writing Makefile for Devel::PPPort
Writing MYMETA.yml and MYMETA.json
rm -rf Devel-PPPort-3.52
"/usr/local/perl/perls/perl-5.26.2/bin/perl" "-MExtUtils::Manifest=manicopy,maniread" \
		-e "manicopy(maniread(),'Devel-PPPort-3.52', 'best');"
Problem opening MANIFEST: No such file or directory at /usr/local/perl/perls/perl-5.26.2/lib/5.26.2/ExtUtils/Manifest.pm line 349.
mkdir Devel-PPPort-3.52
Generating META.yml
Generating META.json
Could not add META.yml to MANIFEST: Could not open MANIFEST: No such file or directory at /usr/local/perl/perls/perl-5.26.2/lib/5.26.2/ExtUtils/Manifest.pm line 723.

atoomic added a commit to atoomic/Devel-PPPort that referenced this issue May 17, 2019
Fixes GH Dual-Life#68

make sure we regenerate the manifest
when building a dist.

We recently removed on purpose the
MANIFEST file from the git repo to
make sure we always generate a fresh
version on dist...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant