Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize motif half life model code? #111

Open
ewallace opened this issue Apr 13, 2021 · 1 comment
Open

Reorganize motif half life model code? #111

ewallace opened this issue Apr 13, 2021 · 1 comment
Labels
fix-after-draft analysis code, to clean up after we have a complete manuscript draft

Comments

@ewallace
Copy link
Collaborator

Currently:

  • train_half_life_linear_model.R organizes the data and then does the training/ motif search, that takes several minutes to run.
  • and train_half_life_linear_model.R also outputs some plot panels.
  • all those outputs go through a .Rdata binary file that isn't committed to the repo.
  • hlife_model_extract_motif_coef.R does a mixture of new linear modeling for selected coefficients, making a new coefficient plot, and assembling a multipanel plot.

This makes it difficult and time-consuming to edit the figure formatting by itself. And hard to follow.

Can we make this easier at all? Separate the plotting from the calculation, or pass the data round more nicely?

@ewallace ewallace added the fix-after-draft analysis code, to clean up after we have a complete manuscript draft label Apr 13, 2021
@ewallace
Copy link
Collaborator Author

Maybe if train_half_life_linear_model.R could output a flat table combined_hlife_data_sets, containing everything needed for the figures. Also a flat table (comibned?) of coefficients. Then we could load and use those for building figures in the other script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix-after-draft analysis code, to clean up after we have a complete manuscript draft
Projects
None yet
Development

No branches or pull requests

1 participant