Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mouse position looks like wrong when connect to windows on macos #507

Open
binbowang1987 opened this issue Jul 26, 2024 · 2 comments
Open
Labels
A-native-client Area: Native client (ironrdp-client) bug Something isn't working help wanted Extra attention is needed

Comments

@binbowang1987
Copy link

./target/debug/ironrdp-client -u username -p 'xxxx' 172.17.56.83

image

@CBenoit CBenoit added bug Something isn't working help wanted Extra attention is needed A-native-client Area: Native client (ironrdp-client) labels Jul 26, 2024
@CBenoit
Copy link
Member

CBenoit commented Jul 26, 2024

Do you think you could look into this? I don’t have a MacOS machine I can test on easily.

The mouse position is handed to us by winit at this place:

WindowEvent::CursorMoved { position, .. } => {
// FIXME: allow physical position for HiDPI remote
// + should take display scale into account
let sf = window.scale_factor();
let operation = ironrdp::input::Operation::MouseMove(ironrdp::input::MousePosition {
x: (position.x / sf) as u16,
y: (position.y / sf) as u16,
});
let input_events = input_database.apply(std::iter::once(operation));
send_fast_path_events(&input_event_sender, input_events);
}

I see there is a FIXME about HiDPI remotes. Is your remote machine HiDPI?

@binbowang1987
Copy link
Author

Yes, my remote machine is HiDPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-native-client Area: Native client (ironrdp-client) bug Something isn't working help wanted Extra attention is needed
Development

No branches or pull requests

2 participants