Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Scancodes for native ironrdp-client incorrect on MacOS #180

Open
ibeckermayer opened this issue Aug 22, 2023 · 3 comments
Open

Scancodes for native ironrdp-client incorrect on MacOS #180

ibeckermayer opened this issue Aug 22, 2023 · 3 comments
Assignees
@CBenoit
Labels
A-native-client Area: Native client (ironrdp-client) bug Something isn't working good first issue Good for newcomers P-medium Medium priority

Comments

@ibeckermayer
Copy link
Collaborator

MacOS uses different scancodes from windows and thus the native client requires a translation layer for MacOS.
@ibeckermayer ibeckermayer added the bug Something isn't working label Aug 22, 2023
@CBenoit CBenoit added the good first issue Good for newcomers label Aug 22, 2023
@CBenoit
Copy link
Member

CBenoit commented Aug 22, 2023 •
edited
Loading

I’m thinking about a HashMap mapping from macOS to Windows scancodes.
@thenextman any input on this?

@CBenoit CBenoit added the A-native-client Area: Native client (ironrdp-client) label Aug 22, 2023
@thenextman
Copy link
Member

@CBenoit IIRC FreeRDP does a two-step mapping: they go from "system" key code to "virtual" key code, and from "virtual" key codes to scan codes. They should already have the tables etc. Check the input module in winpr to start.

@CBenoit
Copy link
Member

CBenoit commented Aug 22, 2023

Thank you for the pointer!

@CBenoit CBenoit added the P-medium Medium priority label Nov 1, 2023
@CBenoit CBenoit self-assigned this Nov 1, 2023
@CBenoit CBenoit mentioned this issue Dec 7, 2023
Open
@CBenoit CBenoit mentioned this issue Mar 14, 2024
Closed
@zmrush zmrush mentioned this issue Jul 2, 2024
Closed
@zmrush zmrush mentioned this issue Jul 18, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CBenoit CBenoit

Labels
A-native-client Area: Native client (ironrdp-client) bug Something isn't working good first issue Good for newcomers P-medium Medium priority
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: scancodes for native ironrdp-client incorrect on MacOS zmrush/IronRDP
3 participants
@thenextman @CBenoit @ibeckermayer