From d67f74ff999d11868753a2d10ca0c509865d608f Mon Sep 17 00:00:00 2001 From: Rickard Andersson Date: Thu, 10 Dec 2020 12:55:38 +0100 Subject: [PATCH] Update README and add comment regarding windows artifact naming --- README.md | 3 ++- config.forge.js | 2 ++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 14c9fc2..0a944cc 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,8 @@ Unzip `github-pr-tool-macOS.zip` and drag `github-pr-tool.app` to your Applicati The first time you launch the app, you must right click it and choose "open" two times. On the second time you will get the option to trust the application. ### Windows -Coming soon. +Run the `github-pr-tool-windows.exe` file. +First time you run the app it might be blocked due to not being trusted. There should be some option to allow it to run anyway. ## Development diff --git a/config.forge.js b/config.forge.js index 91a7920..0762faf 100644 --- a/config.forge.js +++ b/config.forge.js @@ -28,6 +28,8 @@ module.exports = { console.log(`Artifact for ${result.arch}/${result.platform} packaged to: ${artifactPath}`); if (artifactPath.includes("squirrel.windows")) { + // Uses the version specified in package.json + // TODO: Make windows artifact naming more consistent with other platforms artifactPath = artifactPath.replace("RELEASES", "github-pr-tool-1.0.0 Setup.exe"); } const pathParts = artifactPath.split(".");