Don't accept result values with . #2303
Conversation
ynr/apps/utils/widgets.py
Outdated
| @@ -43,7 +43,7 @@ def build_attrs(self, base_attrs, extra_attrs=None): | |||
| attrs.update( | |||
| { | |||
| "inputmode": "numeric", | |||
| "pattern": r"[0-9\s\.,]*", | |||
| "pattern": r"[0-9\s\,]*", | |||
There was a problem hiding this comment.
backslash (\) is the escape character for regex, except you don't need to escape , so I'm not sure if it's doing anything - this makes it confusing. It was in front of . because . is a wildcard in regex, but I'm not sure even that was necessary when enclosed in square brackets...
There was a problem hiding this comment.
I've fixed this up as suggested.
@pmk01 ^^ could you comment? I personally think accepting it and trying to figure out if it's the same context and mentioned in the issue vs a percentage and cleaning it could get tricky. |
|
We never want decimals (well, we might if we add other electoral systems, but right now, no). We don't want people to add percentages either. |
VirginiaDooley
force-pushed
the
hotfix/results-with-decimals
branch
2 times, most recently
from
ee09bf2
to
6dee736
Compare
|
@VirginiaDooley This is good, but based on the decimal point, can you rename this field to |
VirginiaDooley
force-pushed
the
hotfix/results-with-decimals
branch
from
6dee736
to
7b6c43d
Compare
Closes #2300