Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vehicle List #17

Closed
18 tasks done
DanielCaspers opened this issue Nov 22, 2018 · 17 comments
Closed
18 tasks done

Vehicle List #17

DanielCaspers opened this issue Nov 22, 2018 · 17 comments
Assignees
Labels
Feature MyCar Edition The public facing info behind auth
Milestone

Comments

@DanielCaspers
Copy link
Owner

DanielCaspers commented Nov 22, 2018

Motivation
Customers should be able to see all vehicles which they have brought to Murphy Automotive, and perform actions related to them.

Acceptance criteria

@DanielCaspers
Copy link
Owner Author

@scaspers please weigh in whether or not table sorting is a need. If so, I'd like more specifics on which columns, and their behaviors.

@DanielCaspers DanielCaspers added Feature MyCar Edition The public facing info behind auth labels Nov 22, 2018
@DanielCaspers DanielCaspers mentioned this issue Nov 22, 2018
9 tasks
@DanielCaspers DanielCaspers changed the title Vehicle List: Implementation Vehicle List Nov 22, 2018
@DanielCaspers
Copy link
Owner Author

I'd also like to know if you have any data around the number of vehicles that most owners have in their account. I'm trying to figure out if this should be represented with a table, or if a list of rich cards would be better.

@YoMurphy
Copy link
Collaborator

I am assuming "2" above is after a vehicle is selected. Then I would suggest to add 2.4. Recommended Service reminders.

@DanielCaspers
Copy link
Owner Author

@YoMurphy , I caught your drift. I made a documentation mistake. Good catch :)

@DanielCaspers
Copy link
Owner Author

@YoMurphy I'd also be interested to hear your thoughts on if table sort is a need, and how different columns should be sortable if so. I'm asking because I think we should consider using something similar to the vehicle badge we developed in DI for quickly conveying year, make, model and color.

image

@DanielCaspers
Copy link
Owner Author

@scaspers @YoMurphy I'd love your thoughts on my attached wireframes in the description, and if you feel we should start storing an image with the vehicle. We could always do without the image and use the colored name badge, but I think using a vehicle image will give a more premium feel.

@scaspers
Copy link
Collaborator

  • Average number of vehicle per client is approx 2.5. We do have clients with over 100 which are fleets and likely need file updating\cleansing.

  • I am in favor of the vehicle image rather than the color badge. I would then ask the question of who attaches the picture to the vehicle and how might we accomplish that?

  • Maybe vehicle specific coupons\offers would not be visible until they look at Services Needed except for LOF coupons?

@DanielCaspers
Copy link
Owner Author

@scaspers not sure on your third point. What about tire coupons, or cabin air filter and wiper blades? You might not know they are due for those or if they'd get their oil change done with you if also doing tires?

@DanielCaspers
Copy link
Owner Author

DanielCaspers commented Dec 15, 2018

New idea for image fallbacking. We would only show the severity when no img, and superimpose severity over the img when both are available. Could use more alignment work and slightly larger car image.

image

@DanielCaspers DanielCaspers added the Needs stakeholder action Needs action from one or more stakeholders label Dec 15, 2018
@YoMurphy
Copy link
Collaborator

After further discussion I feel the Vehicle list should be the main page or dashboard.
Possibly each vehicle is a widget itself. Example:
-Vehicle Picture icon followed by description.
-4 icons shown- (Service Due or OK) - (Vehicle History) - (Schedule Service) - (Vehicle specific specials)
-Expanded text only if service is due.

DanielCaspers added a commit that referenced this issue Dec 31, 2018
Routes to various features from the sidenav, and begins cleanup
on features started on stackblitz
@DanielCaspers DanielCaspers added this to the v2.0 milestone May 11, 2019
DanielCaspers added a commit that referenced this issue Nov 20, 2019
…le List Data

NOTE: Original stackoverflow code for refresh token implementation was changed due to
race condition issues found with it. Hence a timer() was substituted, which behaves reasonably
well.
DanielCaspers added a commit that referenced this issue Nov 30, 2019
…up, layout improvements

- Finish date and vehicle selection
- Auto-select vehicle when initiated from vehicles list
- Improve vehicle card and container layout
@DanielCaspers DanielCaspers added the Needs API Needs REST API for further progress - work is blocked. label Dec 1, 2019
@DanielCaspers
Copy link
Owner Author

@scaspers @YoMurphy this is blocked from completion until additional API support is available or requirements change.

For the short term, the most important to address are
1.5. LastServiceDate
1.6. LastServiceMileage,

and if you'd like to have it
1.X NextServiceDate
1.Y NextServiceMileage

I currently think we should take "1.8 If available, a thumbnail image of their car" at a later point since this data isn't readily available yet.

Here's the latest behavior of the feature:
MyCar - Murphy Automotive (2)

For fleets and those with lots of vehicles, max view on Desktop gives up to 3 columns.

image

@YoMurphy
Copy link
Collaborator

YoMurphy commented Dec 3, 2019

@DanielCaspers, great work!

  • I would just say "Service needed", remove the s. Service can imply 1 or more, rather than Services would always imply more than 1.
  • The changing icons in from of the "Service Needed" to match the concern may be confusing. Should we just stick to the exclamation point for Service needed. Green check for "No service needed".

@YoMurphy
Copy link
Collaborator

YoMurphy commented Dec 3, 2019

I would also favor the vehicle image background.

@DanielCaspers
Copy link
Owner Author

@YoMurphy, @scaspers and I decided no vehicle image for now until we build our own database of customer vehicle images. That we can always bring in later.

Great catch on the button text! Will change.

I am torn about the level of concern icon. Originally, I had it in the upper left of the card as an overall status of the card. I since moved it to the side of the button to communicate that the icon indicates the vehicle's aggregate level of concern. I am not a fan of thinning down to two icons as then it no longer communicates the same information. If it becomes binary and isn't understood, I would recommend then we put the number of recommended services before the button text. E.g. 2 services needed, 1 service needed.

Given how torn all 3 of us have been about how to handle that, I recommend any further changes for expressing level of concern go through some form of usability testing with employees or close customers first to check our blind spots.

@scaspers
Copy link
Collaborator

1.5. LastServiceDate and 1.6. LastServiceMileage are now included in the clients and vehicles endpoints.

        "vehicleMaintDetails": [
            {
                "lofLastOdometer": -1,
                "lofLastDate": -63309600,
                "lofIntervalDays": null,
                "lofIntervalMiles": null
            }

negative or null values indicate that an oil change has not been done.

@scaspers scaspers removed the Needs API Needs REST API for further progress - work is blocked. label Dec 13, 2019
@DanielCaspers
Copy link
Owner Author

We decided I will add these on the client side. If non null or non-negative, client will add

lofLastOdometer + lofIntervalMiles

lofLastDate + lofIntervalDays

@DanielCaspers DanielCaspers removed the Needs stakeholder action Needs action from one or more stakeholders label Dec 15, 2019
@DanielCaspers
Copy link
Owner Author

@scaspers @YoMurphy all originally agreed upon features here are provided and complete.

We can file a separate issue for moving the recommended services icon if required.

DanielCaspers added a commit that referenced this issue Dec 15, 2019
- Includes misc client requested tweaks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature MyCar Edition The public facing info behind auth
Projects
None yet
Development

No branches or pull requests

3 participants