From 4143ca3fb15ab0383cf5cb655fd322eca0573685 Mon Sep 17 00:00:00 2001 From: elad Date: Thu, 13 Jul 2023 01:50:42 +0300 Subject: [PATCH 1/4] fmmting add no results custom message --- .../data-engine/file-tree/FileList.tsx | 9 ++++++- .../data-engine/file-tree/FileTreeItem.tsx | 5 +++- .../dagshub/data-engine/file-tree/index.tsx | 11 +++++++- .../dagshub/organization/header/index.tsx | 6 ++--- .../modals/add-member-modal/index.tsx | 4 +-- .../organization/tables/teams-table/index.tsx | 8 ++++-- src/components/icons/index.tsx | 26 +++++++++++++------ .../file-tree/FileTree.stories.tsx | 3 ++- 8 files changed, 53 insertions(+), 19 deletions(-) diff --git a/src/components/dagshub/data-engine/file-tree/FileList.tsx b/src/components/dagshub/data-engine/file-tree/FileList.tsx index 9a891a63..65127699 100644 --- a/src/components/dagshub/data-engine/file-tree/FileList.tsx +++ b/src/components/dagshub/data-engine/file-tree/FileList.tsx @@ -8,6 +8,7 @@ interface FileListInterface { selected: string | null; getFilesCb: (id: string) => Promise; setSelected: (id: string) => void; + emptyMessage?: string; } const Loader = () => ( @@ -29,18 +30,24 @@ export const FileList = ({ loading, setSelected, getFilesCb, - selected + selected, + emptyMessage }: FileListInterface) => { if (loading) { return ; } if (!children?.length) { + if (emptyMessage) { + return {emptyMessage}; + } + // fallback return This file is empty; } return ( {children?.map((child: FileListItemType) => ( Promise; @@ -29,7 +30,8 @@ export function FileTreeItem({ getFilesCb, setSelected, type, - href + href, + emptyMessage, }: FileItemInterface) { const [open, setOpen] = useState(false); const [children, setChildren] = useState(null); @@ -136,6 +138,7 @@ export function FileTreeItem({ void; getFilesCb: (id: string) => Promise; } -export const FileTree = ({ list, loading, getFilesCb, onSelect }: FileTreeInterface) => { +export const FileTree = ({ + list, + loading, + getFilesCb, + onSelect, + emptyMessage +}: FileTreeInterface) => { const [selected, setSelected] = useState(null); const handleSetSelected = (id: string) => { @@ -23,6 +30,7 @@ export const FileTree = ({ list, loading, getFilesCb, onSelect }: FileTreeInterf } }; + console.log('emptyMessage', emptyMessage); return ( - - + +
diff --git a/src/components/dagshub/organization/modals/add-member-modal/index.tsx b/src/components/dagshub/organization/modals/add-member-modal/index.tsx index 9bb817c8..bd492a0a 100644 --- a/src/components/dagshub/organization/modals/add-member-modal/index.tsx +++ b/src/components/dagshub/organization/modals/add-member-modal/index.tsx @@ -137,8 +137,8 @@ export function AddMemberModal({ label={`Add new ${isTeam ? 'team' : 'organization'} ${ isOrg && isAdmin ? 'admin' : 'member' }`} - fullWidth={true} - onClick={() => + fullWidth={true} + onClick={() => addMembers({ team, access, diff --git a/src/components/dagshub/organization/tables/teams-table/index.tsx b/src/components/dagshub/organization/tables/teams-table/index.tsx index a1e25068..2756e982 100644 --- a/src/components/dagshub/organization/tables/teams-table/index.tsx +++ b/src/components/dagshub/organization/tables/teams-table/index.tsx @@ -66,7 +66,7 @@ export interface TeamTableProps { copyInvitationAction: (args?: any) => void; existingTeamNames: string[]; addTeamReposLink: string; - addTeamReposAnalyticsEventAction:()=>void; + addTeamReposAnalyticsEventAction: () => void; } export interface OnEditTeamInput { @@ -399,7 +399,11 @@ export function TeamTable({ columns: [ This team doesn't have repositories yet{' '} - + Add team repositories diff --git a/src/components/icons/index.tsx b/src/components/icons/index.tsx index 4b2b32a3..8a1904f8 100644 --- a/src/components/icons/index.tsx +++ b/src/components/icons/index.tsx @@ -1660,7 +1660,7 @@ export const icons = { /> ), - 'beaker': ({ fill, width, height, onClick = () => {} }: IconProp) => ( + beaker: ({ fill, width, height, onClick = () => {} }: IconProp) => ( ), - 'annotations': ({fill, width, height, onClick = () => {}}: IconProp) => ( - - - - - - ), + annotations: ({ fill, width, height, onClick = () => {} }: IconProp) => ( + + + + + + ) }; export type IconType = keyof typeof icons; diff --git a/src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx b/src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx index 4d263f8f..2624632d 100644 --- a/src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx +++ b/src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx @@ -28,7 +28,7 @@ const generateRandOption = (l: number) => { }; const getFilesCb = (value: string) => { - const rndInt = randomIntFromInterval(0, 6); + const rndInt = randomIntFromInterval(0, 2); // mock api call return new Promise((resolve, reject) => { @@ -59,6 +59,7 @@ FileTreeWithFiles.args = { href: '/' } ], + emptyMessage: 'empty message ', onSelect, getFilesCb, loading: false From e7e890e532d762fef49c21baee7b11520857b7b3 Mon Sep 17 00:00:00 2001 From: elad Date: Thu, 13 Jul 2023 11:36:07 +0300 Subject: [PATCH 2/4] remove cl --- src/components/dagshub/data-engine/file-tree/index.tsx | 1 - 1 file changed, 1 deletion(-) diff --git a/src/components/dagshub/data-engine/file-tree/index.tsx b/src/components/dagshub/data-engine/file-tree/index.tsx index 5814b287..e8c71bfc 100644 --- a/src/components/dagshub/data-engine/file-tree/index.tsx +++ b/src/components/dagshub/data-engine/file-tree/index.tsx @@ -30,7 +30,6 @@ export const FileTree = ({ } }; - console.log('emptyMessage', emptyMessage); return ( Date: Thu, 13 Jul 2023 16:49:59 +0300 Subject: [PATCH 3/4] minor changes --- src/components/dagshub/data-engine/file-tree/FileList.tsx | 2 +- src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/components/dagshub/data-engine/file-tree/FileList.tsx b/src/components/dagshub/data-engine/file-tree/FileList.tsx index 65127699..2b53f637 100644 --- a/src/components/dagshub/data-engine/file-tree/FileList.tsx +++ b/src/components/dagshub/data-engine/file-tree/FileList.tsx @@ -41,7 +41,7 @@ export const FileList = ({ return {emptyMessage}; } // fallback - return This file is empty; + return This directory is empty; } return ( diff --git a/src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx b/src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx index 2624632d..30061adf 100644 --- a/src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx +++ b/src/stories/dagshub/data-engine/file-tree/FileTree.stories.tsx @@ -59,7 +59,7 @@ FileTreeWithFiles.args = { href: '/' } ], - emptyMessage: 'empty message ', + emptyMessage: 'no files here', onSelect, getFilesCb, loading: false From 1bb9ad3adda1375d62c7ffe1b0453f4ed382554b Mon Sep 17 00:00:00 2001 From: elad Date: Thu, 13 Jul 2023 17:02:37 +0300 Subject: [PATCH 4/4] fmt --- src/components/dagshub/data-engine/file-tree/FileTreeItem.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/components/dagshub/data-engine/file-tree/FileTreeItem.tsx b/src/components/dagshub/data-engine/file-tree/FileTreeItem.tsx index 5147620b..b07bda36 100644 --- a/src/components/dagshub/data-engine/file-tree/FileTreeItem.tsx +++ b/src/components/dagshub/data-engine/file-tree/FileTreeItem.tsx @@ -31,7 +31,7 @@ export function FileTreeItem({ setSelected, type, href, - emptyMessage, + emptyMessage, }: FileItemInterface) { const [open, setOpen] = useState(false); const [children, setChildren] = useState(null);