Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

decommission waterwatch.py #137

Open
1 of 4 tasks
lstanish-usgs opened this issue Apr 18, 2024 · 3 comments
Open
1 of 4 tasks

decommission waterwatch.py #137

lstanish-usgs opened this issue Apr 18, 2024 · 3 comments

Comments

@lstanish-usgs
Copy link
Collaborator

lstanish-usgs commented Apr 18, 2024

The waterwatch services were recently shut down and the waterwatch function get_flood_stage() has stopped working.
We need to:

  • deprecate the module (remove waterwatch.py from dataretrieval)
  • remove waterwatch.py reference from init.py file
  • add a descriptive commit message: it will show up in the next release
  • review documentation and update/remove examples or references to get_flood_stage() function
@lstanish-usgs
Copy link
Collaborator Author

I did not encounter examples or references to this module in the documentation

@thodson-usgs
Copy link
Collaborator

I know I said "update the changelog" but I think we decided against that from dataretrieval in favor a more automated approach: Give a descriptive commit message like "Remove waterwatch module", then that will appear in the "release notes", when we cut our next release.

@lstanish-usgs
Copy link
Collaborator Author

I know I said "update the changelog" but I think we decided against that from dataretrieval in favor a more automated approach: Give a descriptive commit message like "Remove waterwatch module", then that will appear in the "release notes", when we cut our next release.

Copy that. I'll update the task in the checkbox above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants