Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

앱잼 전 리팩토링 #10

Open
2 of 10 tasks
pump9918 opened this issue Dec 27, 2023 · 0 comments
Open
2 of 10 tasks

앱잼 전 리팩토링 #10

pump9918 opened this issue Dec 27, 2023 · 0 comments

Comments

@pump9918
Copy link
Contributor

pump9918 commented Dec 27, 2023 •
edited
Loading

📌 체크해야할 것

  • oncreate에 binding들은 모두 함수화 시켜라.
  • observe함수명은 LoginObserve처럼 직관적으로
  • string으로 모두다 몰아버리기
  • presentation에 데이터 클래스가 있는게 있음 => 폴더링 잘하기(data 패키지로)
  • toast 따로 빼놓기
  • 주석 지우기(함수명으로 모두 알 수 있게)
  • 함수를 더 잘게 쪼개고 세밀하게 관리
  • viewModel에 서버통신 다 모으기
  • 액티비티와 Fragment에서는 UI에 기능만 담기
  • 뷰페이저 적용

💡참고 사항
pump9918 added a commit that referenced this issue Jan 5, 2024
@pump9918
[fix] #10 String 전체 추출
dbe5f55
pump9918 added a commit that referenced this issue Jan 5, 2024
@pump9918
[feat] #10 뷰페이저 의존성 주입
68f6be4
pump9918 added a commit that referenced this issue Jan 5, 2024
@pump9918
[feat] #10 뷰페이저 xml
7b9f810
pump9918 added a commit that referenced this issue Jan 5, 2024
@pump9918
[feat] #10 뷰페이저 프래그먼트
b12df37
pump9918 added a commit that referenced this issue Jan 5, 2024
@pump9918
[fix] #10 뷰페이저 match_parent 전체 적용
f474343
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pump9918