Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Action synonyms for same AEE or its SYN; revise SCL consistency validation #2371

Open
davidzbiral opened this issue Oct 8, 2024 · 0 comments
Assignees
Labels
validation validation features
Milestone

Comments

@davidzbiral
Copy link
Collaborator

davidzbiral commented Oct 8, 2024

Just as we are checking whether Concept synonyms have the same superclass and report if it does not, we need to report if Action synonyms have an inconsistent AEE. (AEE is important for taxonomy in Actions; we will not check for SCL consistency among Actions synonyms at this point, only for AEE consistency.)
Inconsitent means that their AEE is neither the same not the SYN of one another.

When implementing this, also implement this extension to SYN to the existing SCL checking: if the SCLs are SYN of one another, the entity should pass the test without notification.
E.g.:

  • "(common) meal" has SYN "eating together"
  • "(common) meal" has SCL "meal"
  • "eating together" has SCL "eating"
  • "eating" has SYN "meal"
    in this case "(common) meal" and "eating together" should both pass the test of SCL consistency. Now they do not, because so far we requested same SCL, but we should have requested: same SCL or one of its synonyms.
@davidzbiral davidzbiral added the validation validation features label Oct 8, 2024
@davidzbiral davidzbiral added this to the Finetuning and bugfixing milestone Oct 8, 2024
@davidzbiral davidzbiral changed the title Check Action synonyms for same AEE Check Action synonyms for same AEE or its SYN Oct 10, 2024
@davidzbiral davidzbiral changed the title Check Action synonyms for same AEE or its SYN Check Action synonyms for same AEE or its SYN; refactor SCL consistency validation Oct 10, 2024
@davidzbiral davidzbiral changed the title Check Action synonyms for same AEE or its SYN; refactor SCL consistency validation Check Action synonyms for same AEE or its SYN; revise SCL consistency validation Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
validation validation features
Projects
None yet
Development

No branches or pull requests

2 participants