Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Obsolete OOVPA maintenance #38

Open
RadWolfie opened this issue Aug 23, 2018 · 4 comments
Open

Obsolete OOVPA maintenance #38

RadWolfie opened this issue Aug 23, 2018 · 4 comments
Labels
OOVPA Any OOVPA change relative task

Comments

@RadWolfie
Copy link
Member

Moved from Cxbx-Reloaded/Cxbx-Reloaded#798

Original post by @PatrickvL:

Recently, all OOVPA have been revised.
As a result, we now have OOVPA in our code that are disabled, because these OOVPA where either:

  • moved to another version,
  • replaced by a better declaration,
  • declared entirely wrong,
  • describing an unknown symbol,
  • duplicate to another declaration,
  • too generic,
  • or disabled for another reason.

For this issue:

  • review all disabled OOVPA
  • remove all OOVPA that we can safely do without
  • add notes to the ones that need more attention
  • create an issue with a remaining task list, gained from the previous step
  • report, test and deliver the above results and then close this issue
@RadWolfie RadWolfie added OOVPA Any OOVPA change relative task labels Aug 23, 2018
@JayFoxRox
Copy link
Contributor

Can you be more precise?

  • Is it all contained in certain files?
  • Do we know where everything is?

As a beginner on this repo, I feel a bit lost, with terms like "OOVPA" (also see lack of #22), but also the assumption that everyone knows where the respective code is (like this PR).

@PatrickvL
Copy link
Member

PatrickvL commented Jan 29, 2019

The Cxbx-Reloaded wiki has some articles on OOVPAs : https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/wiki/Maintaining-OOVPAs-for-HLE-function-detection#scanning and https://github.com/Cxbx-Reloaded/Cxbx-Reloaded/wiki/HLE-v2-Database-Method

@RadWolfie and/or @jarupxx (being the two people most recently working on OOVPA maintenance) should best be able to judge the current state of this issue.

@RadWolfie
Copy link
Member Author

The issue remain open since there are some OOVPAs left unused and other disabled. It is being work on.

@RadWolfie
Copy link
Member Author

I notice there's removal of obsolete OOVPAs from Cxbx-Reloaded repo. I recently found out from one of Voxel9's branch with re-add Rtl signatures. These removal should be investigate and determine if worthy to re-add, in need of better signatures, or simply false positive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OOVPA Any OOVPA change relative task
Projects
None yet
Development

No branches or pull requests

3 participants