Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GetTypeInformation_(4|8) wording bug #209

Open
RadWolfie opened this issue Aug 3, 2024 · 0 comments
Open

GetTypeInformation_(4|8) wording bug #209

RadWolfie opened this issue Aug 3, 2024 · 0 comments
Labels
bug Something isn't working task XAPI OOVPA relative topic

Comments

@RadWolfie
Copy link
Member

As I was going through with #208 pull request for XAPI symbol group inspection for parameters... I recently discovered both GetTypeInformation_4 and GetTypeInformation_8 symbols are not standard call functions. Instead they are fastcall functions. So, the parameters are stored in registers instead of onto stack. The pull request doesn't supplied registers onto symbol string for non-LTCG libraries are static generated. A decision will need to be made how to handle this type of situation. Other symbols so far doesn't have this type of conflict at this time.

I tried to look up for the original review remark in Cxbx-Reloaded repository twice but fail to find it again. I'm leaving this open until able to find the original review remark discussion to be link here. Plus to make further decision after re-review the review remark discussion and possible permanent solution for this problem.

@RadWolfie RadWolfie added task XAPI OOVPA relative topic bug Something isn't working labels Aug 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working task XAPI OOVPA relative topic
Projects
None yet
Development

No branches or pull requests

1 participant