From 94e3ad80cf520e4bb2eef43ec3432c9921fd4ccf Mon Sep 17 00:00:00 2001
From: Luis Rodriguez <luis.rodriguez@cru.org>
Date: Fri, 25 Oct 2024 15:05:58 -0400
Subject: [PATCH] add extra verification

---
 .../build-deploy-cloudrun-function.yml        | 38 ++++++++++++-------
 1 file changed, 25 insertions(+), 13 deletions(-)

diff --git a/.github/workflows/build-deploy-cloudrun-function.yml b/.github/workflows/build-deploy-cloudrun-function.yml
index d3e8c7b..ed87345 100644
--- a/.github/workflows/build-deploy-cloudrun-function.yml
+++ b/.github/workflows/build-deploy-cloudrun-function.yml
@@ -73,20 +73,32 @@ jobs:
       - name: Set up Cloud SDK
         uses: google-github-actions/setup-gcloud@v2
 
-      - name: Preprocess Config File
+      - name: Check for empty variables
         run: |
-          echo "sed_command=s|${FUNCTION_NAME}|${{ inputs.function_name }}|g; \
-              s|${GCP_REGION}|${{ secrets.GCP_REGION }}|g; \
-              s|${GCP_PROJECT_ID}|${{ secrets.GCP_PROJECT_ID }}|g; \
-              s|${GCP_SERVICE_ACCOUNT_EMAIL}|${{ secrets.GCP_SERVICE_ACCOUNT_EMAIL }}|g; \
-              s|${RUN_SERVICE_ACCOUNT}|${{ secrets.RUN_SERVICE_ACCOUNT }}|g" >> $GITHUB_ENV
-          
-          sed -e "s|${FUNCTION_NAME}|${{ inputs.function_name }}|g; \
-            s|${GCP_REGION}|${{ secrets.GCP_REGION }}|g; \
-            s|${GCP_PROJECT_ID}|${{ secrets.GCP_PROJECT_ID }}|g; \
-            s|${GCP_SERVICE_ACCOUNT_EMAIL}|${{ secrets.GCP_SERVICE_ACCOUNT_EMAIL }}|g; \
-            s|${RUN_SERVICE_ACCOUNT}|${{ secrets.RUN_SERVICE_ACCOUNT }}|g" \
-          function_config_template.json > function_config.json
+          if [ -z "${{ inputs.function_name }}" ] || 
+             [ -z "${{ secrets.GCP_REGION }}" ] || 
+             [ -z "${{ secrets.GCP_PROJECT_ID }}" ] || 
+             [ -z "${{ secrets.GCP_SERVICE_ACCOUNT_EMAIL }}" ] || 
+             [ -z "${{ secrets.RUN_SERVICE_ACCOUNT }}" ]; then
+            echo "One or more required variables are empty."
+            exit 1
+          fi
+
+      - name: Construct and print sed command
+        id: print_command
+        run: |
+          sed_command="s|${FUNCTION_NAME}|${{ inputs.function_name }}|g; \
+                       s|${GCP_REGION}|${{ secrets.GCP_REGION }}|g; \
+                       s|${GCP_PROJECT_ID}|${{ secrets.GCP_PROJECT_ID }}|g; \
+                       s|${GCP_SERVICE_ACCOUNT_EMAIL}|${{ secrets.GCP_SERVICE_ACCOUNT_EMAIL }}|g; \
+                       s|${RUN_SERVICE_ACCOUNT}|${{ secrets.RUN_SERVICE_ACCOUNT }}|g"
+
+          echo "Running sed command: $sed_command"
+          eval "echo \"$sed_command\""
+
+      - name: Execute sed command
+        run: |
+          eval "sed -e \"$sed_command\" function_config_template.json > function_config.json"
 
       - name: Verify Config File
         run: cat function_config.json