Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potentially useful PRs #18

Closed
The-EDev opened this issue Oct 18, 2020 · 2 comments
Closed

potentially useful PRs #18

The-EDev opened this issue Oct 18, 2020 · 2 comments
Assignees
Labels
task Non code related issue

Comments

@The-EDev
Copy link
Member

The-EDev commented Oct 18, 2020

the following PRs could be useful.

they should probably be cloned, tested (thoroughly, we don't need another sendifle), cleaned up, and merged.

@The-EDev The-EDev self-assigned this Oct 18, 2020
@The-EDev The-EDev added the task Non code related issue label Oct 18, 2020
@The-EDev
Copy link
Member Author

The-EDev commented Oct 18, 2020

ipkn/crow#352

Note: Do not merge, add setting or option to select the time first.
"HTTP dates are always expressed in GMT, never in local time." -MDN
localtime could be used for logs, but ATM this isn't a big deal


ipkn/crow#115

Note: PR was closed, why? Also the PR is old enough that the changes need to be re-implemented into http-server.h .


ipkn/crow#144

Note: was closed because it doesn't take Accept-Encoding into consideration.


ipkn/crow#329

Note: possible conflicts with the previous PR.


ipkn/crow#328

Note: seems straightforward and simple enough.


ipkn/crow#312

Note: Test failed because of boost version, requires checking still.


ipkn/crow#275

Note: Simple change, Replicate issue before considering.
Already implemented


ipkn/crow#250

Note: PR seemingly useless, discussion sounds like it has instructions on a proper implementation.

@The-EDev
Copy link
Member Author

The-EDev commented Nov 9, 2020

all PRs are either implemented, canceled, or in their own Issues.

@The-EDev The-EDev closed this as completed Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
task Non code related issue
Projects
None yet
Development

No branches or pull requests

1 participant