Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confusing "module does not own channel capability" when passing wrong channel #1742

Open
taitruong opened this issue Nov 27, 2023 · 3 comments
Assignees

Comments

@taitruong
Copy link

I was passing a wrong channgel belonging to another contract. So it wasn't my module/(IBC) contract, but the wrong channel I passed.

return nil, nil, errorsmod.Wrap(channeltypes.ErrChannelCapabilityNotFound, "module does not own channel capability")

@alpe
Copy link
Contributor

alpe commented Nov 28, 2023

Contracts can only send ibc packets on channels that are connected to them. Otherwise it would be easy to abuse.
I can see that the error message may be confusing though. When we tested this early, the scenario to prevent was more contracts sending to other ibc modules like ics20 transfer.
Would contract does not own channel capability be a better error message?

@pinosu
Copy link
Contributor

pinosu commented Dec 5, 2023

Hi @taitruong , could you please give us feedback if would contract does not own channel capability be a better error message? Thank you

@taitruong
Copy link
Author

Hi @taitruong , could you please give us feedback if would contract does not own channel capability be a better error message? Thank you

Yes, way better, ser!

@pinosu pinosu self-assigned this Dec 11, 2023
@pinosu pinosu added this to the v0.53.0 milestone Jul 25, 2024
@pinosu pinosu removed this from the v0.53.0 milestone Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants