Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMU should read less in exoModule and use less the CallStackReader #689

Closed
letypequividelespoubelles opened this issue Apr 19, 2024 · 2 comments · Fixed by #988
Closed

MMU should read less in exoModule and use less the CallStackReader #689

letypequividelespoubelles opened this issue Apr 19, 2024 · 2 comments · Fixed by #988
Assignees
@letypequividelespoubelles
Labels
cleaning Make the code easier to read by cleaning it perf Increase performances

Comments

@letypequividelespoubelles
Copy link
Collaborator

  • Hub could give directly sourceRam / targetRam. One less call to callStackReader if the src / tgt is the currentFrame
  • for exoBytes, MMU could get it from the ram when it's an ram to exo instructions. For exoToRamStransplant too when copying precompile result, as it's already written in the tgt ram fictitious context number
@letypequividelespoubelles letypequividelespoubelles added the perf Increase performances label Apr 19, 2024
@powerslider powerslider changed the title MMU should read less in exoModule and unes less callStackReader MMU should read less in exoModule and use less the CallStackReader May 14, 2024
@letypequividelespoubelles
Copy link
Collaborator Author

given #810, MMU is now given the src / exo RAM when needed, and we could / should safe delete all the callStackReader in MMU

@letypequividelespoubelles
Copy link
Collaborator Author

need to do a clean-up of the MMU

@letypequividelespoubelles letypequividelespoubelles added the cleaning Make the code easier to read by cleaning it label Jul 28, 2024
@letypequividelespoubelles letypequividelespoubelles linked a pull request Aug 27, 2024 that will close this issue
perf(MMU): discard CallStackReader #988
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@letypequividelespoubelles letypequividelespoubelles

Labels
cleaning Make the code easier to read by cleaning it perf Increase performances
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

perf(MMU): discard CallStackReader Consensys/linea-tracer
1 participant
@letypequividelespoubelles