From 3a1bfb0d990008499648324a882f5294639c383d Mon Sep 17 00:00:00 2001
From: David Pearce <david.pearce@consensys.net>
Date: Thu, 3 Oct 2024 03:38:13 +1300
Subject: [PATCH] fix: nightly tests (#1355)

* Fix Nightly Tests

This (hopefully) fixes the nightly tests by: (1) no longer supporting
`corset` for checking constraints (since this runs out of memory on
large traces); (2) uploads the test report after `go-corset` has run.
That will then allow us to see what has gone wrong.

* Renable output for failing tests

This re-enables output to be written to the Github action console for
failing tests.  This has been previously disabled for reasons unknown,
but it ends up hiding important information.
---
 .github/workflows/gradle-nightly-tests.yml | 65 +++-------------------
 gradle/tests.gradle                        |  4 +-
 2 files changed, 10 insertions(+), 59 deletions(-)

diff --git a/.github/workflows/gradle-nightly-tests.yml b/.github/workflows/gradle-nightly-tests.yml
index c234271231..31f5a4d730 100644
--- a/.github/workflows/gradle-nightly-tests.yml
+++ b/.github/workflows/gradle-nightly-tests.yml
@@ -9,64 +9,8 @@ env:
   CARGO_NET_GIT_FETCH_WITH_CLI: true
 
 jobs:
-  tests:
+  nightly-tests:
     runs-on: ubuntu-latest-128
-    steps:
-      - uses: webfactory/ssh-agent@v0.7.0
-        with:
-          ssh-private-key: |
-            ${{ secrets.CONSTRAINTS_SSH_KEY }}
-
-      - name: Checkout repository
-        uses: actions/checkout@v3
-        with:
-          submodules: recursive
-
-      - name: Set up JDK 21
-        uses: actions/setup-java@v3
-        with:
-          java-version: 21
-          distribution: temurin
-
-      - name: Install Rust
-        uses: actions-rust-lang/setup-rust-toolchain@v1
-
-      # The asset URL for the latest release can be found with:
-      # curl -L -H "Accept: application/vnd.github+json"  \
-      #     -H "Authorization: Bearer YOUR_GH_API_TOKEN" \
-      #     -H "X-GitHub-Api-Version: 2022-11-28" \
-      #     https://api.github.com/repos/ConsenSys/corset/releases/latest
-      # | jq '.assets[] | select(.name|endswith("x86_64-unknown-linux-musl.tar.gz")) | .url'
-      - name: Install Corset
-        run: RUSTFLAGS=-Awarnings cargo install --git ssh://git@github.com/ConsenSys/corset --tag v9.7.13 --locked --force
-#        run: |
-#          curl -L \
-#          -H "Accept: application/octet-stream" \
-#          -H "Authorization: Bearer ${{ secrets.GITHUB_TOKEN }}" \
-#          -H "X-GitHub-Api-Version: 2022-11-28" \
-#          -o corset.tar.gz \
-#          https://api.github.com/repos/Consensys/corset/releases/assets/151396061
-#          tar xzf corset.tar.gz
-#          mv corset $HOME
-#          echo $HOME >> $GITHUB_PATH
-
-      - name: Run Nightly tests
-        run: ./gradlew nightlyTests
-        env:
-          JAVA_OPTS: -Dorg.gradle.daemon=false
-          CORSET_FLAGS: fields,expand,expand,expand
-          NIGHTLY_TESTS_PARALLELISM: 4
-
-      - name: Upload test report
-        if: always()
-        uses: actions/upload-artifact@v3
-        with:
-          name: nightly-tests-report
-          path: build/reports/tests/**/*
-
-  go-corset-tests:
-    runs-on: ubuntu-latest-128
-    continue-on-error: true    
     steps:
       - uses: webfactory/ssh-agent@v0.7.0
         with:
@@ -102,3 +46,10 @@ jobs:
           JAVA_OPTS: -Dorg.gradle.daemon=false
           CORSET_FLAGS: disable
           GOCORSET_FLAGS: -wd --ansi-escapes=false --report --air
+
+      - name: Upload test report
+        if: always()
+        uses: actions/upload-artifact@v3
+        with:
+          name: nightly-tests-report
+          path: build/reports/tests/**/*
diff --git a/gradle/tests.gradle b/gradle/tests.gradle
index 4f470e954d..072af11b88 100644
--- a/gradle/tests.gradle
+++ b/gradle/tests.gradle
@@ -98,7 +98,7 @@ tasks.withType(Test).configureEach {
     showSkipped false
 
     // set to false to hide failed tests
-    showFailed false
+    showFailed true
 
     // enable to see standard out and error streams inline with the test results
     showStandardStreams true
@@ -110,7 +110,7 @@ tasks.withType(Test).configureEach {
     showSkippedStandardStreams false
 
     // set to false to hide failed standard out and error streams
-    showFailedStandardStreams false
+    showFailedStandardStreams true
   }
 
   useJUnitPlatform()