Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory Usage During Trace Expansion #307

Closed
DavePearce opened this issue Sep 11, 2024 · 3 comments · Fixed by #315
Closed

Memory Usage During Trace Expansion #307

DavePearce opened this issue Sep 11, 2024 · 3 comments · Fixed by #315

Comments

@DavePearce
Copy link
Collaborator

There appears to be an issue where trace expansion can lead to very high memory usage on very large traces. This is likely to be partly caused by concurrency generating high memory pressure. Therefore, batching go-routines could reduce this pressure.

@achintya-7
Copy link

Hey @DavePearce
I would like to work on this issue.
Adding a worker-queue here for limiting number of go-routines should help with memory.

@DavePearce
Copy link
Collaborator Author

Well, at this stage, its not a particularly big problem for us. I have used batch processing for the various parts which have helped.

@achintya-7
Copy link

Well, at this stage, its not a particularly big problem for us. I have used batch processing for the various parts which have helped.

Ah cool.
Well I did implement a generic worker queue and incorporated it with this function. If you want, I can raise a PR.

@DavePearce DavePearce linked a pull request Oct 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants