Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

timezone issues with game date #37

Open
ConorSheehan1 opened this issue Oct 20, 2023 · 1 comment · May be fixed by #44
Open

timezone issues with game date #37

ConorSheehan1 opened this issue Oct 20, 2023 · 1 comment · May be fixed by #44
Labels
bug Something isn't working

Comments

@ConorSheehan1
Copy link
Owner

ConorSheehan1 commented Oct 20, 2023 •
edited
Loading

Users have reported issues related to new games starting at unexpected times, and getting the same game twice

Possible causes:

  1. Truncating date time here

    spelling-bee/src/store.ts

    Line 103 in 1dd95c5

    return this.getGameDate.toISOString().split("T")[0];

    May need to store date + timezone info, and call to isoString for all comparisons
    already storing gameDate and lastGameDate as date object. Need more info from users

    spelling-bee/src/store.ts

    Line 18 in aac7b96

    gameDate: useStorage("gameDate", epoch as Date),
@ConorSheehan1 ConorSheehan1 added the bug Something isn't working label Oct 20, 2023
@stelcodes
Copy link

I've ran into this bug too and it's pretty frustrating. I'm attempting to fix it rn.

@stelcodes stelcodes linked a pull request Jul 10, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix bug causing games to restart at incorrect times stelcodes/spelling-bee
2 participants
@ConorSheehan1 @stelcodes