Tests are randomly failing

[graywolf]

Tests are failing based on execution order.

:( $ /usr/bin/ruby -w -I"lib:test" -I"/tmp/rb-readline/.bundle/vendor/ruby/2.5.0/gems/rake-12.3.1/lib" "/tmp/rb-readline/.bundle/vendor/ruby/2.5.0/gems/rake-12.3.1/lib/rake/rake_test_loader.rb" "test/test_completion.rb" "test/test_filename_completion_proc.rb" "test/test_history.rb" "test/test_rbreadline.rb" "test/test_readline.rb" 
/tmp/rb-readline/lib/rbreadline.rb:3485: warning: assigned but unused variable - i
/tmp/rb-readline/lib/rbreadline.rb:5420: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:5503: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:5595: warning: assigned but unused variable - incoming_length
/tmp/rb-readline/lib/rbreadline.rb:7145: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:7789: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:8098: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:14: warning: method redefined; discarding old ord
Run options: --seed 37230

# Running:

.......DEPRECATED: Use assert_nil if expecting nil from /tmp/rb-readline/test/test_readline.rb:127. This will fail in Minitest 6.
.......DEPRECATED: Use assert_nil if expecting nil from /tmp/rb-readline/test/test_readline.rb:194. This will fail in Minitest 6.
.......................EEEE..........

Finished in 0.169333s, 301.1813 runs/s, 549.2130 assertions/s.

  1) Error:
TestFilenameCompletionProc#test_list_files_in_current_directory:
ArgumentError: comparison of String with nil failed
    /tmp/rb-readline/lib/rbreadline.rb:1401:in `sort'
    /tmp/rb-readline/lib/rbreadline.rb:1401:in `compute_lcd_of_matches'
    /tmp/rb-readline/lib/rbreadline.rb:1305:in `rl_completion_matches'
    /tmp/rb-readline/lib/readline.rb:488:in `call'
    /tmp/rb-readline/test/test_filename_completion_proc.rb:69:in `test_list_files_in_current_directory'

  2) Error:
TestFilenameCompletionProc#test_listing_files_in_cwd:
ArgumentError: comparison of String with nil failed
    /tmp/rb-readline/lib/rbreadline.rb:1401:in `sort'
    /tmp/rb-readline/lib/rbreadline.rb:1401:in `compute_lcd_of_matches'
    /tmp/rb-readline/lib/rbreadline.rb:1305:in `rl_completion_matches'
    /tmp/rb-readline/lib/readline.rb:488:in `call'
    /tmp/rb-readline/test/test_filename_completion_proc.rb:44:in `block in test_listing_files_in_cwd'
    /tmp/rb-readline/test/test_filename_completion_proc.rb:42:in `chdir'
    /tmp/rb-readline/test/test_filename_completion_proc.rb:42:in `test_listing_files_in_cwd'

  3) Error:
TestFilenameCompletionProc#test_list_files_and_directories_with_spaces:
ArgumentError: comparison of String with nil failed
    /tmp/rb-readline/lib/rbreadline.rb:1401:in `sort'
    /tmp/rb-readline/lib/rbreadline.rb:1401:in `compute_lcd_of_matches'
    /tmp/rb-readline/lib/rbreadline.rb:1305:in `rl_completion_matches'
    /tmp/rb-readline/lib/readline.rb:488:in `call'
    /tmp/rb-readline/test/test_filename_completion_proc.rb:65:in `test_list_files_and_directories_with_spaces'

  4) Error:
TestFilenameCompletionProc#test_list_files_in_sub_directories:
ArgumentError: comparison of String with nil failed
    /tmp/rb-readline/lib/rbreadline.rb:1401:in `sort'
    /tmp/rb-readline/lib/rbreadline.rb:1401:in `compute_lcd_of_matches'
    /tmp/rb-readline/lib/rbreadline.rb:1305:in `rl_completion_matches'
    /tmp/rb-readline/lib/readline.rb:488:in `call'
    /tmp/rb-readline/test/test_filename_completion_proc.rb:51:in `test_list_files_in_sub_directories'

51 runs, 93 assertions, 0 failures, 4 errors, 0 skips
rake aborted!
Command failed with status (1): [ruby -w -I"lib:test" -I"/tmp/rb-readline/.bundle/vendor/ruby/2.5.0/gems/rake-12.3.1/lib" "/tmp/rb-readline/.bundle/vendor/ruby/2.5.0/gems/rake-12.3.1/lib/rake/rake_test_loader.rb" "test/test_completion.rb" "test/test_filename_completion_proc.rb" "test/test_history.rb" "test/test_rbreadline.rb" "test/test_readline.rb" ]
/tmp/rb-readline/.bundle/vendor/ruby/2.5.0/gems/rake-12.3.1/exe/rake:27:in `<top (required)>'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/cli/exec.rb:74:in `load'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/cli/exec.rb:74:in `kernel_load'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/cli/exec.rb:28:in `run'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/cli.rb:424:in `exec'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/vendor/thor/lib/thor/command.rb:27:in `run'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/vendor/thor/lib/thor/invocation.rb:126:in `invoke_command'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/vendor/thor/lib/thor.rb:387:in `dispatch'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/cli.rb:27:in `dispatch'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/vendor/thor/lib/thor/base.rb:466:in `start'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/cli.rb:18:in `start'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/exe/bundle:30:in `block in <top (required)>'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/lib/bundler/friendly_errors.rb:124:in `with_friendly_errors'
/home/wolf/.gem/ruby/2.5.0/gems/bundler-1.16.5/exe/bundle:22:in `<top (required)>'
/home/wolf/.gem/ruby/2.5.0/bin/bundle:23:in `load'
/home/wolf/.gem/ruby/2.5.0/bin/bundle:23:in `<main>'
Tasks: TOP => test
(See full trace by running task with --trace)
+
[ wolf@ws ] :: /tmp/rb-readline
Load: 0.50 0.31 0.21 , Memory: 18.38 %, Disk: 24 %
:( $ /usr/bin/ruby -w -I"lib:test" -I"/tmp/rb-readline/.bundle/vendor/ruby/2.5.0/gems/rake-12.3.1/lib" "/tmp/rb-readline/.bundle/vendor/ruby/2.5.0/gems/rake-12.3.1/lib/rake/rake_test_loader.rb" "test/test_completion.rb" "test/test_filename_completion_proc.rb" "test/test_history.rb" "test/test_rbreadline.rb" "test/test_readline.rb" 
/tmp/rb-readline/lib/rbreadline.rb:3485: warning: assigned but unused variable - i
/tmp/rb-readline/lib/rbreadline.rb:5420: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:5503: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:5595: warning: assigned but unused variable - incoming_length
/tmp/rb-readline/lib/rbreadline.rb:7145: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:7789: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:8098: warning: parentheses after method name is interpreted as an argument list, not a decomposed argument
/tmp/rb-readline/lib/rbreadline.rb:14: warning: method redefined; discarding old ord
Run options: --seed 53461

# Running:

...............DEPRECATED: Use assert_nil if expecting nil from /tmp/rb-readline/test/test_readline.rb:194. This will fail in Minitest 6.
......DEPRECATED: Use assert_nil if expecting nil from /tmp/rb-readline/test/test_readline.rb:127. This will fail in Minitest 6.
..............................

Finished in 0.157324s, 324.1709 runs/s, 622.9167 assertions/s.

51 runs, 98 assertions, 0 failures, 0 errors, 0 skips