Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues when requiring 'rb-readline' #124

Open
abinoam opened this issue Sep 10, 2015 · 1 comment
Open

Issues when requiring 'rb-readline' #124

abinoam opened this issue Sep 10, 2015 · 1 comment

Comments

@abinoam
Copy link

abinoam commented Sep 10, 2015

I was not able to make it work as the README file states.

Looking at the code at:

I have made my way with this fragment of code:

# This will remove old Readline if it's already defined
require 'rb-readline'

# This will load RbReadline for real
require 'rbreadline'

# This will load Readline that relies on RbReadline
require 'readline'

The README says we should do

require 'readline'

I think it is a little confusing to ask someone to require the gem with "another" name.
And the chances of name collision in bug situations are greater.

IMHO, the 'canonical' way of requiring rb-readline should be simple as:

require 'rb-readlne'

What are the maintainers opinion on this?

If you agree I'll try to find some time to offer a patch for that (don't promise, but I can try).
But, if somebody wants to give a try sooner, feel free to do it.

@Spakman
Copy link
Collaborator

Spakman commented Oct 20, 2015

Requiring RbReadline is a tricky business. I've been looking around for my various experiments with loading the library in a clean way, but alas they seem to have disappeared into the ether along with my memory of the problems I encountered.

I do remember that because Readline is part of the stdlib, this is a very awkward library to require. Sorry this isn't more help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants