Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weffc++-warning: ‘class constHybridVector<double>’ has pointer data members #62

Open
slizzered opened this issue Jun 8, 2015 · 1 comment
Open

Weffc++-warning: ‘class constHybridVector<double>’ has pointer data members #62

slizzered opened this issue Jun 8, 2015 · 1 comment
Labels
warning
Milestone
1.6 HASEonALPAKA

Comments

@slizzered
Copy link
Contributor

When compiling with -Weffc++11, there appears a new warning. Might be related to #18

include/cuda_utils.hpp:98:7: warning: ‘class constHybridVector<double>’ has pointer data members [-Weffc++]
 class constHybridVector {
       ^
include/cuda_utils.hpp:98:7: warning:   but does not override ‘constHybridVector<double>(const constHybridVector<double>&)’ [-Weffc++]
include/cuda_utils.hpp:98:7: warning:   or ‘operator=(const constHybridVector<double>&)’ [-Weffc++]
@slizzered slizzered added this to the 1.5 - extended features milestone Jun 8, 2015
erikzenker pushed a commit to erikzenker/haseongpu that referenced this issue Jul 2, 2015
Workaround to free device memory
28c7eba 
* ConstHybridVector provices the method free to manually free device memory
* A better solution would be a reference counting implementation,
  but there is no out of the box solution like boost::shared_ptr
* Leaves ComputationalRadiationPhysics#62 still open (smart pointers necessary)
* closes: ComputationalRadiationPhysics#18
erikzenker pushed a commit to erikzenker/haseongpu that referenced this issue Jul 2, 2015
Workaround to free device memory
df9e51f 
* ConstHybridVector provices the method free to manually free device memory
* A better solution would be a reference counting implementation,
  but there is no out of the box solution like boost::shared_ptr
* Leaves ComputationalRadiationPhysics#62 still open (smart pointers necessary)
* closes: ComputationalRadiationPhysics#18
@erikzenker erikzenker mentioned this issue Jul 2, 2015
Merged
@erikzenker
Copy link
Member

By introducing smart pointers, this warning should be removed. A quick
google search gave me a cuda smart pointer implementation. I hope its quick and nice 🌈

@slizzered slizzered modified the milestones: 1.5 - extended features, 1.4 Graybat, usability and Windows compatibility, 1.6 HASEonANY Sep 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
warning
Projects
None yet
Milestone
1.6 HASEonALPAKA
Development

No branches or pull requests
2 participants
@erikzenker @slizzered