Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to not deflate before base64 encode #26

Open
dmg2 opened this issue Mar 28, 2018 · 3 comments
Open

Option to not deflate before base64 encode #26

dmg2 opened this issue Mar 28, 2018 · 3 comments

Comments

@dmg2
Copy link

dmg2 commented Mar 28, 2018

I am working with an implementation that does not deflate before base64 encoding. It seems SAML raider does this as default, because of this it is causing all my requests to be interpreted as malformed. Is there a way to force SAML raider to not deflate?

@emanuelduss
Copy link
Member

Thanks for reporting.

Depending on where the SAML Message is (either as a GET or a POST parameter), the output it deflates the request or not. I'll try to fix this issue the next time I work on the project.

I could add a dropdown to do it a) automatically b) always deflate c) never deflate.

@dmg2
Copy link
Author

dmg2 commented Mar 28, 2018

I didn't want to wait so I cloned the repo and started to modify the decompress and compress functions. I hard coded it to work the niche way I need it for this project. However, it turns out that I have more issues that this one. For some reason when I url decode/base 64 decode CHANGE NOTHING then base 64 encode/url encode the result is different. That difference is making my service provider drop me every time. You would think that not modifying any values would still yield similar results. I am sort of at a loss, not sure what to do.

I thought perhaps I made a mistake in my code. So i decided to do it manually using website url encode/decode and base 64 encode/decode. I got the same results as I did with my code. It seems that somehow when the message is first decoded it either gains or losses some whitespace or line breaks or something similar. It is very difficult to tell what is being gained and lost because the message look identical.

@emanuelduss
Copy link
Member

Thanks for your explanation. I'll look into that the next time I have time to work on the project (not sure when exactly).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants