Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand tests #5

Open
nic-hartley opened this issue Oct 11, 2018 · 4 comments
Open

Expand tests #5

nic-hartley opened this issue Oct 11, 2018 · 4 comments
Assignees
Labels
feature Something should be added

Comments

@nic-hartley
Copy link
Member

nic-hartley commented Oct 11, 2018

We want 100% coverage as close to right off the bat as possible. While this isn't strictly necessary for MVP, it makes coding a lot more comfortable. We should focus on unit tests, but if possible create integration tests as well.

@nic-hartley nic-hartley added feature Something should be added up for grabs Anyone is free to take this and implement it labels Oct 11, 2018
@nic-hartley nic-hartley modified the milestones: 0.1, 1.0 Oct 11, 2018
@nic-hartley nic-hartley removed this from the Open Source milestone Nov 5, 2018
@nic-hartley nic-hartley added this to the MVP milestone Nov 5, 2018
@nic-hartley nic-hartley changed the title Expand unit tests Expand tests Nov 5, 2018
@nic-hartley
Copy link
Member Author

Let's do this once #2 / #19 is complete.

@nic-hartley nic-hartley self-assigned this Nov 6, 2018
@nic-hartley nic-hartley removed the up for grabs Anyone is free to take this and implement it label Nov 6, 2018
@nic-hartley nic-hartley modified the milestones: MVP, Open Source Nov 13, 2018
@nic-hartley nic-hartley removed their assignment Nov 19, 2018
@nic-hartley nic-hartley added the up for grabs Anyone is free to take this and implement it label Nov 19, 2018
@nic-hartley
Copy link
Member Author

Change of plans; we're focusing on integration tests now.

@zachtjones
Copy link
Contributor

zachtjones commented Nov 20, 2018

For testing frameworks, here are some good ones that I've used in other projects to much success:

  • AssertJ, http://joel-costigliola.github.io/assertj/, which makes our assertions much cleaner
  • JGiven, which enables any tests to fit into the Given/When/Then pattern
  • JUnit5 parameterized tests, which allows us to cover all bases for a particular Unit/endpoint collection

JGiven will be this one if we use JUnit5 (which I'd recommend)

<dependency>
	<groupId>com.tngtech.jgiven</groupId>
	<artifactId>jgiven-junit5</artifactId>
	<version>0.16.1</version>
	<scope>test</scope>
</dependency>

@nic-hartley nic-hartley self-assigned this Nov 22, 2018
@nic-hartley nic-hartley removed the up for grabs Anyone is free to take this and implement it label Nov 22, 2018
@nic-hartley nic-hartley modified the milestones: Beta, Public Production Dec 1, 2018
@nic-hartley
Copy link
Member Author

Some notes:

  • JGiven, Spring, and JUnit 5 don't seem to work together at all.
  • JaCoCo doesn't seem to integrate with JGiven and I have no idea why (I'm working on that now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Something should be added
Projects
None yet
Development

No branches or pull requests

2 participants