Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Highlight doesn't work in Clip and VAE outputs #1204

Open
LukeG89 opened this issue Oct 10, 2024 · 1 comment
Open

[Bug]: Highlight doesn't work in Clip and VAE outputs #1204

LukeG89 opened this issue Oct 10, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@LukeG89
Copy link

LukeG89 commented Oct 10, 2024

Frontend Version

1.3.16

Expected Behavior

Clip and VAE outputs should highlight when grabbing a link from their input types.

Actual Behavior

Clip and VAE outputs are not highlighted.

Steps to Reproduce

No_Output_Highlight_Clip_Vae.mp4

Debug Logs

E:\>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build --disable-all-custom-nodes --disable-xformers --preview-size 1024 --front-end-version Comfy-Org/ComfyUI_frontend@latest
Total VRAM 8192 MB, total RAM 65277 MB
pytorch version: 2.4.1+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Ti Laptop GPU : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: E:\ComfyUI\web_custom_versions\Comfy-Org_ComfyUI_frontend\1.3.16
E:\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead.
  @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
Skipping loading of custom nodes
Starting server

To see the GUI go to: http://127.0.0.1:8188

Browser Logs

No errors.

What browsers do you use to access the UI ?

Google Chrome

Other

I noticed this behavior only on Clip and VAE, I don't know if there are other types with the same issue.

@LukeG89 LukeG89 added the Potential Bug Untriaged bug label Oct 10, 2024
@huchenlei huchenlei added bug Something isn't working and removed Potential Bug Untriaged bug labels Oct 10, 2024
@huchenlei
Copy link
Member

Hmmm, this must be a very old bug. I verified that v1.0.0 has this bug already. Thanks for flagging this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants