Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Logging extension patches console even when disabled #1166

Open
christian-byrne opened this issue Oct 8, 2024 · 0 comments
Open

[Bug]: Logging extension patches console even when disabled #1166

christian-byrne opened this issue Oct 8, 2024 · 0 comments
Labels
Potential Bug Untriaged bug

Comments

@christian-byrne
Copy link
Collaborator

christian-byrne commented Oct 8, 2024

Frontend Version

1.3.11

Expected Behavior

Turn the logging feature off:

Selection_479

Afterward, the logging extension should not patch console messages.

Actual Behavior

Even when logging is disabled, the console messages are patched, making it harder to use browser debugger

Selection_480

Steps to Reproduce

  1. Disable logging
  2. Reload page and observe that log messages, warnings, errors are harder to trace because their source is logging.ts

Browser Logs

api.ts:48 Running on localhost:8188
03:38:05.948 logging.ts:332 ComfyUI Front-end version: 1.3.11
03:38:06.118 api.ts:75 
        
        
       GET http://localhost:8188/api/userdata/workflows%2F.index.json net::ERR_ABORTED 404 (Not Found)
fetchApi @ api.ts:75
getUserData @ api.ts:596
loadBookmarks @ workflowStore.ts:87
wrappedAction @ pinia.mjs:1405
loadWorkflows @ workflows.ts:70
setup @ app.ts:1831
await in setup
(anonymous) @ GraphCanvas.vue:141
(anonymous) @ runtime-core.esm-bundler.js:1808
callWithErrorHandling @ runtime-core.esm-bundler.js:195
callWithAsyncErrorHandling @ runtime-core.esm-bundler.js:202
hook.__weh.hook.__weh @ runtime-core.esm-bundler.js:1788
flushPostFlushCbs @ runtime-core.esm-bundler.js:379
flushJobs @ runtime-core.esm-bundler.js:415
Promise.then
queueFlush @ runtime-core.esm-bundler.js:319
queuePostFlushCb @ runtime-core.esm-bundler.js:339
queueEffectWithSuspense @ runtime-core.esm-bundler.js:1760
scheduler @ runtime-core.esm-bundler.js:6113
resetScheduling @ reactivity.esm-bundler.js:262
triggerEffects @ reactivity.esm-bundler.js:306
triggerRefValue @ reactivity.esm-bundler.js:1071
set value @ reactivity.esm-bundler.js:1118
finalizeNavigation @ vue-router.mjs:3460
(anonymous) @ vue-router.mjs:3325
Promise.then
pushWithRedirect @ vue-router.mjs:3292
push @ vue-router.mjs:3217
install @ vue-router.mjs:3659
use @ runtime-core.esm-bundler.js:2984
(anonymous) @ main.ts:28
Show 21 more frames
Show lessUnderstand this error
1203:38:06.215 Fetch finished loading: GET "<URL>".
03:38:06.135 api.ts:75 Fetch failed loading: GET "http://localhost:8188/api/userdata/workflows%2F.index.json".
fetchApi @ api.ts:75
getUserData @ api.ts:596
loadBookmarks @ workflowStore.ts:87
wrappedAction @ pinia.mjs:1405
loadWorkflows @ workflows.ts:70
setup @ app.ts:1831
await in setup
(anonymous) @ GraphCanvas.vue:141
(anonymous) @ runtime-core.esm-bundler.js:1808
callWithErrorHandling @ runtime-core.esm-bundler.js:195
callWithAsyncErrorHandling @ runtime-core.esm-bundler.js:202
hook.__weh.hook.__weh @ runtime-core.esm-bundler.js:1788
flushPostFlushCbs @ runtime-core.esm-bundler.js:379
flushJobs @ runtime-core.esm-bundler.js:415
Promise.then
queueFlush @ runtime-core.esm-bundler.js:319
queuePostFlushCb @ runtime-core.esm-bundler.js:339
queueEffectWithSuspense @ runtime-core.esm-bundler.js:1760
scheduler @ runtime-core.esm-bundler.js:6113
resetScheduling @ reactivity.esm-bundler.js:262
triggerEffects @ reactivity.esm-bundler.js:306
triggerRefValue @ reactivity.esm-bundler.js:1071
set value @ reactivity.esm-bundler.js:1118
finalizeNavigation @ vue-router.mjs:3460
(anonymous) @ vue-router.mjs:3325
Promise.then
pushWithRedirect @ vue-router.mjs:3292
push @ vue-router.mjs:3217
install @ vue-router.mjs:3659
use @ runtime-core.esm-bundler.js:2984
(anonymous) @ main.ts:28
Show 21 more frames
Show less
03:38:06.786 components-manager.js:769 Empty components: policy ignored
03:38:06.847 api.ts:75 Fetch finished loading: POST "http://localhost:8188/api/manager/component/loads".
fetchApi @ api.ts:75
load_components @ components-manager.js:67
setup @ comfyui-manager.js:1340
(anonymous) @ app.ts:405
#invokeExtensionsAsync @ app.ts:402
setup @ app.ts:1912
await in setup
(anonymous) @ GraphCanvas.vue:141
(anonymous) @ runtime-core.esm-bundler.js:1808
callWithErrorHandling @ runtime-core.esm-bundler.js:195
callWithAsyncErrorHandling @ runtime-core.esm-bundler.js:202
hook.__weh.hook.__weh @ runtime-core.esm-bundler.js:1788
flushPostFlushCbs @ runtime-core.esm-bundler.js:379
flushJobs @ runtime-core.esm-bundler.js:415
Promise.then
queueFlush @ runtime-core.esm-bundler.js:319
queuePostFlushCb @ runtime-core.esm-bundler.js:339
queueEffectWithSuspense @ runtime-core.esm-bundler.js:1760
scheduler @ runtime-core.esm-bundler.js:6113
resetScheduling @ reactivity.esm-bundler.js:262
triggerEffects @ reactivity.esm-bundler.js:306
triggerRefValue @ reactivity.esm-bundler.js:1071
set value @ reactivity.esm-bundler.js:1118
finalizeNavigation @ vue-router.mjs:3460
(anonymous) @ vue-router.mjs:3325
Promise.then
pushWithRedirect @ vue-router.mjs:3292
push @ vue-router.mjs:3217
install @ vue-router.mjs:3659
use @ runtime-core.esm-bundler.js:2984
(anonymous) @ main.ts:28
Show 20 more frames
Show less
03:38:06.905 nodeDefStore.ts:371 XHR finished loading: GET "http://localhost:8188/assets/sorted-custom-node-map.json".
dispatchXhrRequest @ xhr.js:195
xhr @ xhr.js:15
dispatchRequest @ dispatchRequest.js:51
_request @ Axios.js:173
request @ Axios.js:40
Axios$1.<computed> @ Axios.js:199
wrap @ bind.js:5
loadNodeFrequencies @ nodeDefStore.ts:371
wrappedAction @ pinia.mjs:1405
(anonymous) @ GraphCanvas.vue:215
await in (anonymous)
(anonymous) @ runtime-core.esm-bundler.js:1808
callWithErrorHandling @ runtime-core.esm-bundler.js:195
callWithAsyncErrorHandling @ runtime-core.esm-bundler.js:202
hook.__weh.hook.__weh @ runtime-core.esm-bundler.js:1788
flushPostFlushCbs @ runtime-core.esm-bundler.js:379
flushJobs @ runtime-core.esm-bundler.js:415
Promise.then
queueFlush @ runtime-core.esm-bundler.js:319
queuePostFlushCb @ runtime-core.esm-bundler.js:339
queueEffectWithSuspense @ runtime-core.esm-bundler.js:1760
scheduler @ runtime-core.esm-bundler.js:6113
resetScheduling @ reactivity.esm-bundler.js:262
triggerEffects @ reactivity.esm-bundler.js:306
triggerRefValue @ reactivity.esm-bundler.js:1071
set value @ reactivity.esm-bundler.js:1118
finalizeNavigation @ vue-router.mjs:3460
(anonymous) @ vue-router.mjs:3325
Promise.then
pushWithRedirect @ vue-router.mjs:3292
push @ vue-router.mjs:3217
install @ vue-router.mjs:3659
use @ runtime-core.esm-bundler.js:2984
(anonymous) @ main.ts:28
Show 28 more frames
Show less
03:38:06.905 api.ts:75 Fetch failed loading: POST "http://localhost:8188/api/settings/Comfy.NodeLibrary.Bookmarks".

What browsers do you use to access the UI ?

Google Chrome

@christian-byrne christian-byrne added the Potential Bug Untriaged bug label Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Untriaged bug
Projects
None yet
Development

No branches or pull requests

1 participant