Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Inconsistent saved/unsaved status #1165

Open
LukeG89 opened this issue Oct 8, 2024 · 1 comment
Open

[Bug]: Inconsistent saved/unsaved status #1165

LukeG89 opened this issue Oct 8, 2024 · 1 comment
Labels
Potential Bug Untriaged bug

Comments

@LukeG89
Copy link

LukeG89 commented Oct 8, 2024

Frontend Version

1.3.11

Expected Behavior

Saved and unsaved status should reflect the current state of the workflows.

Actual Behavior

Saved and unsaved status has become even more inconsistent.

Steps to Reproduce

  • If you create a new workflow and save it, even if you modify it, it still keeps the saved status.
    • The status properly works only after closing and reopening it.
  • If you open as existing workflow inside a subfolder and click "save", the status remains as unsaved even though it's saved.
    • During this second test I also catch a bug that make a new tab opens before the already opened one.
Saved_Status_Inconsistency.mp4

Debug Logs

E:\>.\python_embeded\python.exe -s ComfyUI\main.py --windows-standalone-build --disable-all-custom-nodes --disable-xformers --preview-size 1024 --front-end-version Comfy-Org/ComfyUI_frontend@latest
Total VRAM 8192 MB, total RAM 65277 MB
pytorch version: 2.4.1+cu124
Set vram state to: NORMAL_VRAM
Device: cuda:0 NVIDIA GeForce RTX 3070 Ti Laptop GPU : cudaMallocAsync
Using pytorch cross attention
[Prompt Server] web root: E:\ComfyUI\web_custom_versions\Comfy-Org_ComfyUI_frontend\1.3.11
E:\python_embeded\Lib\site-packages\kornia\feature\lightglue.py:44: FutureWarning: `torch.cuda.amp.custom_fwd(args...)` is deprecated. Please use `torch.amp.custom_fwd(args..., device_type='cuda')` instead.
  @torch.cuda.amp.custom_fwd(cast_inputs=torch.float32)
Skipping loading of custom nodes
Starting server

To see the GUI go to: http://127.0.0.1:8188

Browser Logs

This error occurs when I save the workflow inside subfolder that keeps the unsaved status:

workflows.ts:427 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'load')
    at Proxy._save (workflows.ts:427:22)
    at async Proxy.save (workflows.ts:263:15)

I also got this error when clicking on the dropdown menu, I don't know if it's related to the issue or not:

Blocked aria-hidden on a <a> element because the element that 
just received focus must not be hidden from assistive technology users. 
Avoid using aria-hidden on a focused element or its ancestor. 
Consider using the inert attribute instead, which will also prevent focus. 
For more details, see the aria-hidden section of the WAI-ARIA specification 
at https://w3c.github.io/aria/#aria-hidden. 
<a data-v-2ec1b620 class=​"p-menubar-item-link" tabindex=​"-1" aria-hidden=​"true" data-pc-section=​"itemlink">​…​</a>​flex

What browsers do you use to access the UI ?

Google Chrome

@LukeG89 LukeG89 added the Potential Bug Untriaged bug label Oct 8, 2024
@LukeG89 LukeG89 changed the title [Bug]: Saved/Unsaved status inconsistency | Saving changes seed in before generate mode [Bug]: Inconsistent saved/unsaved status | Saving workflow changes seed in control_before_generate mode Oct 8, 2024
@LukeG89 LukeG89 changed the title [Bug]: Inconsistent saved/unsaved status | Saving workflow changes seed in control_before_generate mode [Bug]: Inconsistent saved/unsaved status Oct 10, 2024
@LukeG89
Copy link
Author

LukeG89 commented Oct 15, 2024

Update: I guess the issue has been introduced in this commit: a95a6f9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Potential Bug Untriaged bug
Projects
None yet
Development

No branches or pull requests

1 participant