Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run pin with importlib.metadata.version #27

Closed
redeboer opened this issue Oct 7, 2024 · 0 comments · Fixed by #29
Closed

Run pin with importlib.metadata.version #27

redeboer opened this issue Oct 7, 2024 · 0 comments · Fixed by #29
Assignees
@redeboer
Labels
⚙️ Enhancement Improvements and optimizations of existing features
Milestone
0.0.10

Comments

@redeboer
Copy link
Member

redeboer commented Oct 7, 2024 •
edited
Loading

The pin() function currently gets the package version from the .constraints/ files. We should use importlib.metadata.version() instead or as an alternative. This becomes particularly important for ComPWA/policy#404, when the .constraints/ files are replaced with uv.lock.
@redeboer redeboer self-assigned this Oct 7, 2024
@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Oct 7, 2024
@redeboer redeboer mentioned this issue Oct 10, 2024
Merged
@redeboer redeboer added this to the 0.0.10 milestone Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@redeboer redeboer

Labels
⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Milestone
0.0.10
Development

Successfully merging a pull request may close this issue.

ENH: get pin() version from importlib if no constraints ComPWA/sphinx-api-relink
1 participant
@redeboer