Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write spin magnitude and projection as Fraction #158

Open
redeboer opened this issue Feb 22, 2022 · 0 comments · May be fixed by #288
Open

Write spin magnitude and projection as Fraction #158

redeboer opened this issue Feb 22, 2022 · 0 comments · May be fixed by #288
Assignees
@grayson-helmholz
Labels
⚙️ Enhancement Improvements and optimizations of existing features ⚠️ Interface Breaking changes to the API

Comments

@redeboer
Copy link
Member

Spin and State.spin_projection are currently float. This is annoying in testing whether a spin is integer or half. A way out may be to use fractions.Fraction. Note that it has to be verified if this works well with the constraints solver.
@redeboer redeboer added 🔨 Maintenance Maintenance and upkeep improvements ⚠️ Interface Breaking changes to the API labels Feb 22, 2022
@redeboer redeboer self-assigned this Feb 22, 2022
@redeboer redeboer added the 💫 Good first issue Good for newcomers label Feb 22, 2022
@redeboer redeboer removed their assignment Feb 22, 2022
@redeboer redeboer added this to the 0.10.0 milestone Mar 7, 2022
@redeboer redeboer self-assigned this Mar 7, 2022
@redeboer redeboer removed 💫 Good first issue Good for newcomers ⚠️ Interface Breaking changes to the API labels Mar 7, 2022
@redeboer redeboer removed this from the 0.10.0 milestone Apr 6, 2022
@redeboer redeboer removed their assignment Jan 9, 2024
@redeboer redeboer mentioned this issue Aug 9, 2024
Closed
@redeboer redeboer added ⚠️ Interface Breaking changes to the API ⚙️ Enhancement Improvements and optimizations of existing features and removed 🔨 Maintenance Maintenance and upkeep improvements labels Sep 5, 2024
@grayson-helmholz grayson-helmholz linked a pull request Oct 4, 2024 that will close this issue
ENH: use Fraction for spin values #288
Draft
@redeboer redeboer assigned redeboer and unassigned redeboer Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@grayson-helmholz grayson-helmholz

Labels
⚙️ Enhancement Improvements and optimizations of existing features ⚠️ Interface Breaking changes to the API
Projects
Student projects
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ENH: use Fraction for spin values ComPWA/qrules
2 participants
@redeboer @grayson-helmholz