Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to pyright-python pre-commit hook #412

Closed
redeboer opened this issue Oct 8, 2024 · 1 comment
Closed

Switch to pyright-python pre-commit hook #412

redeboer opened this issue Oct 8, 2024 · 1 comment
Assignees
Labels
⚙️ Enhancement Improvements and optimizations of existing features

Comments

@redeboer
Copy link
Member

redeboer commented Oct 8, 2024

Since ComPWA/pyright-pre-commit#1, we should to the pre-commit hook offered by pyright-python. This also works better with #407, as it is a Python hook, not NodeJS.

@redeboer redeboer added the ⚙️ Enhancement Improvements and optimizations of existing features label Oct 8, 2024
@redeboer redeboer added this to the 0.4.2 milestone Oct 8, 2024
@redeboer redeboer self-assigned this Oct 8, 2024
@redeboer
Copy link
Member Author

redeboer commented Oct 9, 2024

Seems that it will be hard to make pyright-python work in any venv until #404, when it is guaranteed that the virtual environment is located in ./.venv.

Pre-commit will install pyright-python in its own virtual environment which can cause pyright to not be able to detect your installed dependencies.
https://github.com/RobertCraigie/pyright-python?tab=readme-ov-file#pre-commit

@redeboer redeboer closed this as not planned Won't fix, can't repro, duplicate, stale Oct 9, 2024
@redeboer redeboer removed this from the 0.4.2 milestone Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚙️ Enhancement Improvements and optimizations of existing features
Projects
None yet
Development

No branches or pull requests

1 participant