Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve canopy temp jacobian #782

Open
juliasloan25 opened this issue Sep 19, 2024 · 0 comments
Open

improve canopy temp jacobian #782

juliasloan25 opened this issue Sep 19, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@juliasloan25
Copy link
Member

Is your feature request related to a problem? Please describe.
In #675, we switched canopy temperature to be stepped implicitly. There is some behavior that suggests the jacobian approximation used could be improved - specifically these two points described in that PR:

There are two things I dont understand about this change:

  • there seem to be some times during the simultation where the error is always large, and a smaller dt doesnt help. For example, the 99th percentile error curve dips below the mean error for small dt, which indicates there are outliers that are very large in the top 1% error
    • update 9/18: it's possible this may happen during times in the simulation where temperature is changing a lot, e.g. shortly after a driver update, as opposed to when the temperature is in equilibrium. See plots in comments for more information
  • the derivative of SHF with respect to temperature is correct to a few percent, but the derivative of LHF with respect to temeperature is ~30% wrong. This is partly due to d_qsat/d_T errors (but Ive double checked that I entered the formula correct), but seems like it is also due to d_LHF/d_qsat. I think I have followed CLM exactly. Not sure why the error is large.

We should look into this more and see if we can use a better jacobian approximation that alleviates these issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant