-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] Manipulate image destination based on source #115
Comments
Hey Woudan, Can the example at https://github.com/ChristofferNissen/helmper/blob/main/example/helmper.yaml help answer your question? - name: argo-cd
version: 5.51.4
repo:
name: argo
url: https://argoproj.github.io/argo-helm/
images:
exclude:
- ref: ghcr.io/dexidp/dex
excludeCopacetic:
- ref: quay.io/argoproj/argocd
modify:
- from: quay.io/argoproj/argocd
to: quay.io/argoproj/argocd
- fromValuePath: global.image.repository
to: quay.io/argoproj/argocd |
Hi ChristofferNissen, Correct that with this feature we can manipulate the source right? What I would like to do is change the destination based on which registry is resides from. What I would like to do per helm chart or as general configuration is change a the destination registry slightly. This way we could push dynamically based on registry that we receive images from. In our destination registry I would like to be able to distinguish from what registry the images are received. For quay.io/argoproj/argocd:v2.9.2 the destionation would change from: registry.local/repo/argoproj/argocd -> registry.local/repo/quay/argoproj/argocd based on the quay source. Hope that makes sense. |
I think i got it. This is not currently supported, but i see the value in adding it. I am leaving a few links to places the code needs to be modified if you want to take on the job, otherwise i will look at it once i am done with my current feature. registries:
- name: registry
url: localhost:5000
insecure: true
plainHTTP: true
- name: registry
url: localhost:5001
insecure: true
plainHTTP: true
appendImageSourceToDestination: true
appendChartSourceToDestination: true |
It would be useful to manipulate the image destination based on the source.
For example:
destination: registry.local/repo/dockerhub
destination: registry.local/repo/quay
For quay.io/argoproj/argocd:v2.9.2 this would result in:
registry.local/repo/argoproj/argocd to registry.local/repo/quay/argoproj/argocd
This way we can keep the context of the registry from which the image originates from.
The text was updated successfully, but these errors were encountered: