Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix subtitle download issue, ensure subtitles download as .srt files #6624

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Fix subtitle download issue, ensure subtitles download as .srt files #6624

wants to merge 1 commit into from

Conversation

sanjayr-12
Copy link

@sanjayr-12 sanjayr-12 commented Sep 25, 2024 •
edited
Loading

Description

This PR resolves the problem where subtitles were opening in a new tab instead of downloading as a file.

Changes:

  • Updated the subtitle download logic to use fetch and blob for proper file download.
  • Ensured that the downloaded file has the correct .srt extension.

Related issues

Resolves: #6623

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this PR does not update server code
  • 🙋 no, because I need help

@Chocobozzz
Copy link
Owner

Hi & thank you for your work 🙏

But please use the same methods as other downloads:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Status: Waiting for changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Download subtitles issue
2 participants
@sanjayr-12 @Chocobozzz