Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Long Form Videos Fail to Transcode #6622

Open
MattyBoombalatty opened this issue Sep 25, 2024 · 4 comments
Open

Long Form Videos Fail to Transcode #6622

MattyBoombalatty opened this issue Sep 25, 2024 · 4 comments
Labels
Status: Waiting for answer Waiting issue author answer

Comments

@MattyBoombalatty
Copy link

Describe the current behavior

Long-form videos with transcription enabled will fail to publish after transcoding. I have the 480p and original resolution transcoded. In the admin panel, all the resolutions are there plus the audio only file, but it stays on "waiting for transcode".

Please note that even after disabling transcription and re-running the transcoding job, the result is the same (transcoding fails). An example can be found here

When the transcoding job is forced, this is the error:

{
  "type": "new-resolution-to-web-video",
  "videoUUID": "8554f991-4152-48cd-97ff-e3aaf38bd9fb",
  "isNewVideo": false,
  "resolution": 480,
  "fps": 30,
  "hasChildren": false
}
TypeError: Cannot read properties of undefined (reading 'toActivityPubObject')
    at file:///var/www/peertube/versions/peertube-v6.3.0/dist/core/models/video/formatter/video-activity-pub-format.js:176:21
    at Array.map (<anonymous>)
    at buildIcon (file:///var/www/peertube/versions/peertube-v6.3.0/dist/core/models/video/formatter/video-activity-pub-format.js:176:10)
    at videoModelToActivityPubObject (file:///var/www/peertube/versions/peertube-v6.3.0/dist/core/models/video/formatter/video-activity-pub-format.js:38:317)
    at VideoModel.toActivityPubObject (file:///var/www/peertube/versions/peertube-v6.3.0/dist/core/models/video/video.js:881:33)
    at sendUpdateVideo (file:///var/www/peertube/versions/peertube-v6.3.0/dist/core/lib/activitypub/send/send-update.js:19:37)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async federateVideoIfNeeded (file:///var/www/peertube/versions/peertube-v6.3.0/dist/core/lib/activitypub/videos/federate.js:18:9)
    at async moveToPublishedState (file:///var/www/peertube/versions/peertube-v6.3.0/dist/core/lib/video-state.js:107:5)
    at async /var/www/peertube/versions/peertube-v6.3.0/node_modules/sequelize/lib/sequelize.js:507:18

Steps to reproduce

No response

Describe the expected behavior

No response

Additional information

  • PeerTube instance:

  • Browser name, version and platforms on which you could reproduce the bug:

  • Link to browser console log if relevant:

  • Link to server log if relevant (journalctl or /var/www/peertube/storage/logs/):

@Chocobozzz
Copy link
Owner

Thanks! The root cause of the issue if the video doesn't have a thumbnail/preview which is very weird. Do you know how you uploaded this video?

@Chocobozzz Chocobozzz added the Status: Waiting for answer Waiting issue author answer label Sep 25, 2024
@MattyBoombalatty
Copy link
Author

This was a live stream from another user. I wonder... Let me see what happens if I upload a thumbnail and then redo the transcoding. I have custom video thumbnails so it's entirely possible I didn't replace the default ones correctly.

@MattyBoombalatty
Copy link
Author

Okay, manually uploading a thumbnail and then re-transcoding fixed the issue. I wonder why it's not automatically generating thumbnails for all videos...

@MattyBoombalatty
Copy link
Author

I reset the video thumbnail generation sizes back to normal (I had doubled them) so we'll see if that works.

thumbnails:

  # When automatically generating a thumbnail from the video

  generation_from_video:

    # How many frames to analyze at the middle of the video to select the most appropriate one

    # Increasing this value will increase CPU and memory usage when generating the thumbnail, especially for high video resolution

    # Minimum value is 2

    frames_to_analyze: 20
  # Only two sizes are currently supported for now (not less, not more)
  # 1 size for the thumbnail (displayed in video miniatures)
  # 1 size for the preview (displayed in the video player)
  sizes:
    -
      width: 280 # 280
      height: 157 # 157

    -
      width: 850 # 850
      height: 480 # 480

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Waiting for answer Waiting issue author answer
Projects
None yet
Development

No branches or pull requests

2 participants