Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace geography.geom_coverage with geography.geom_coverage() #1724

Open
juanluisrto opened this issue Mar 11, 2021 · 1 comment
Open

Replace geography.geom_coverage with geography.geom_coverage() #1724

juanluisrto opened this issue Mar 11, 2021 · 1 comment

Comments

@juanluisrto
Copy link

To see the area covered by the geography of a dataset, we can call

Dataset.get("dataset_id").geom_coverage()

and the output is a nice cartoframes map.

However, this is not working with geographies, where Geography.get("geom_id").geom_coverage() method does not exist. What does exists is the attribute Geography.get("geom_id").geom_coverage, which outputs a useless binary object.

Can this be fixed?

@Jesus89
Copy link
Member

Jesus89 commented Mar 11, 2021

The dataset.geom_coverage() loads the WKB data from the geography.geom_coverage and this is not compatible with a map geography.geom_coverage() because it's already defined as a property.

The solution is really simple to implement (it requires renaming the property), but I would ask @alejandrohall @xavipereztr for the original reasons of the current implementation. Also, feel free to provide a PR with the change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants