Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hooktest build fails unexpectedly on Correct xml:lang attribute #104

Open
nevenjovanovic opened this issue Jul 8, 2017 · 4 comments
Open

Hooktest build fails unexpectedly on Correct xml:lang attribute #104

nevenjovanovic opened this issue Jul 8, 2017 · 4 comments

Comments

@nevenjovanovic
Copy link

My files on Travis fail to build repeatedly; for all files, the same error is reported: "Correct xml:lang attribute". All files pass hooktest locally (">>> [success] 260 over 260 texts have fully passed the tests"). Their xml:lang attributes hold the value 'lat', and they are in the text node, together with the xml:base, for example:

/teiHeader>
  <text xml:lang="lat" xml:base="urn:cts:latty:aemilianus01.latty2570222.latty-lat1:">
    <body n="body1">
      <div n="div1">
@nevenjovanovic
Copy link
Author

nevenjovanovic commented Jul 8, 2017 •
edited
Loading

After I have copied the xml:lang attributes to the body elements, the build test in Travis passes. But the location of the obligatory xml:lang attribute is not clear from the documentation, the tests seem to differ from the local hooktest, and I see no reason why it should not be in the text element.
Passing:

<body xml:lang="lat" n="body1">

@PonteIneptique
Copy link
Member

You surely have a different version than online, but that's not the problem. I'll have a look about the specs, which seems to be the issue here.

@PonteIneptique
Copy link
Member

Looking at the specs :

If the text is normal TEI, the convention is to supply the URN the following xpath : TEI/text/body/@n
For normal TEI, it is also possible to supply the URN as the value of an @xml:base attribute in the following xpath: TEI/text/@xml:base

The same node should have an xml:lang attribute stating the language of the text.

The issue here is that we allowed urn on text in the tests but we did not reuse it for the xml:lang. @sonofmun could you add this in the tests when you have the time ?

@sonofmun
Copy link
Contributor

sonofmun commented Jul 2, 2018

@nevenjovanovic @PonteIneptique Was this fixed with #113?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@PonteIneptique @sonofmun @nevenjovanovic