Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"complete" event not dispatched on Android after playing a remote audio asset #134

Open
sgilroy opened this issue Sep 24, 2024 · 0 comments · May be fixed by #135
Open

"complete" event not dispatched on Android after playing a remote audio asset #134

sgilroy opened this issue Sep 24, 2024 · 0 comments · May be fixed by #135

Comments

@sgilroy
Copy link

sgilroy commented Sep 24, 2024

Describe the bug
When using NativeAudio.addListener('complete', ...) to listen for the complete event, the event should be dispatched after the audio finishes playing. On Android, when playing an asset from a remote url (https://) the complete event is never dispatched.

To Reproduce
Steps to reproduce the behavior:

  1. Prepare a project that targets Android
  2. NativeAudio.preload({ assetId: "sample", assetPath: "https://download.samplelib.com/mp3/sample-3s.mp3", audioChannelNum: 1, isUrl: false })
  3. NativeAudio.addListener("complete", event => console.log("complete", event))
  4. NativeAudio.play({ assetId: "sample" })

Expected behavior
The complete event should be logged, but it is not.

@sgilroy sgilroy linked a pull request Sep 25, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant