Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOUBLE_SLASH format breaks when using a URL in a header #26

Open
broccolai opened this issue Apr 30, 2021 · 1 comment · May be fixed by #32
Open

DOUBLE_SLASH format breaks when using a URL in a header #26

broccolai opened this issue Apr 30, 2021 · 1 comment · May be fixed by #32
Labels
type: bug

Comments

@broccolai
Copy link

Using a url results in java.lang.IllegalArgumentException: Header contains unsupported characters //

It's caused by a check in ComponentHeaderFormat here.

Could this be fixed or are URLs unusable when using this format?

Thanks.
@jamierocks
Copy link
Member

Yep, this should be fixed.

joschi added a commit to joschi/licenser that referenced this issue Jul 10, 2021
@joschi
Support double slash within DOUBLE_SLASH style
48a9a39 
Closes CadixDev#26
joschi added a commit to joschi/licenser that referenced this issue Jul 10, 2021
@joschi
Support double slash within DOUBLE_SLASH style
f8eb16d 
Closes CadixDev#26
@joschi joschi linked a pull request Jul 10, 2021 that will close this issue
Open
joschi added a commit to joschi/licenser that referenced this issue Jul 29, 2021
@joschi
Support double slash within DOUBLE_SLASH style
03a46fa 
Closes CadixDev#26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support double slash within DOUBLE_SLASH style joschi/licenser
2 participants
@jamierocks @broccolai