Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential improvements to get_data #5

Open
4 of 6 tasks
maximlt opened this issue Apr 15, 2021 · 1 comment
Open
4 of 6 tasks

Potential improvements to get_data #5

maximlt opened this issue Apr 15, 2021 · 1 comment

Comments

@maximlt
Copy link
Collaborator

maximlt commented Apr 15, 2021

Just listing here some ideas I've got after using the method when doing eodag's documentation.

  • Make the parameters crs, resolution and extent optional
  • Add progress_call optional parameter to pass it down to path_of_downloaded_file = self.download()
  • Document the fact that the data is resampled with a bilinear algorithm (when resolution is set I guess, maybe extent too)
  • If it fails now it returns an empty DataArray, shouldn't it just raise an error?
  • Add attributes coordinates to the returned DataArray. Maybe look whether we could directly read the data with xarray.open_rasterio? Or with rioxarray
  • It'd be nice to directly obtain multiple bands in a xarray.DataSet. band could maybe become bands and accept either a string or a sequence of strings (bands). Or it could be another method.
@maximlt maximlt changed the title Improvements to get_data Potential improvements to get_data Apr 15, 2021
@sbrunato
Copy link
Collaborator

  • Make the parameters crs, resolution and extent optional
  • Document the fact that the data is resampled with a bilinear algorithm (when resolution is set I guess, maybe extent too)

See #25 for optional parameters, also bilinear algorithm is not used by default any more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants