Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix typing after redis-py v5.0.0 release #227

Open
psrok1 opened this issue Sep 1, 2023 · 0 comments
Open

CI: Fix typing after redis-py v5.0.0 release #227

psrok1 opened this issue Sep 1, 2023 · 0 comments
Labels
improvement New feature or request

Comments

@psrok1
Copy link
Member

psrok1 commented Sep 1, 2023

redis-py v5.0.0 adds support for asyncio. It affected return types from command methods which are now Union[Awaitable[T], T]. As the type doesn't really have sense (Awaitable types are returned only if we use Redis class from redis.asyncio package), it's difficult to pass returned values to other typed methods.

I have added temporary workaround for that by dropping the version to <5.0.0 for linting step (#226) but we need to fix it somehow.

@psrok1 psrok1 added the improvement New feature or request label Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant