Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge from AM3 - params #402

Open
JhanSrbinovsky opened this issue Sep 17, 2024 · 2 comments · May be fixed by #404
Open

Merge from AM3 - params #402

JhanSrbinovsky opened this issue Sep 17, 2024 · 2 comments · May be fixed by #404

Comments

@JhanSrbinovsky
Copy link
Collaborator

JhanSrbinovsky commented Sep 17, 2024

This issue covers the merging of code in params/ and utils/ directory from AM3 development.

Null testing against offline will be required here @ccarouge, how do you want to proceed? I'm pretty sure I did this a month or so ago before moving on to the next part of the merge BUT:

  1. I no longer have the output handy
  2. I still haven't used benchcab, I am still using manual pre-cursor to benchcab variety of testing.

Note: Not that it actually changes anything, but technically it does intersect with all applications of CABLE

The overarching issue concerning AM3 merging is here #403

@JhanSrbinovsky JhanSrbinovsky linked a pull request Sep 17, 2024 that will close this issue
3 tasks
@JhanSrbinovsky JhanSrbinovsky linked a pull request Sep 17, 2024 that will close this issue
3 tasks
@ccarouge
Copy link
Collaborator

What is "null testing" ? Is that the same as regression testing?

@JhanSrbinovsky
Copy link
Collaborator Author

I just mean that the regression testing will/should show there is no difference, as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants