Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consistency_ice_veg_soil #338

Closed
rkutteh opened this issue Jul 11, 2024 · 4 comments · Fixed by #349
Closed

consistency_ice_veg_soil #338

rkutteh opened this issue Jul 11, 2024 · 4 comments · Fixed by #349
Assignees
Labels
enhancement New feature or request priority:high High priority issues that should be included in the next release.

Comments

@rkutteh
Copy link
Collaborator

rkutteh commented Jul 11, 2024

Add a subroutine to CABLE to ensure the consistency of ice points between soil and vegetation as described in #280

@rkutteh rkutteh added enhancement New feature or request priority:high High priority issues that should be included in the next release. labels Jul 11, 2024
@rkutteh rkutteh self-assigned this Jul 11, 2024
@har917
Copy link
Collaborator

har917 commented Jul 15, 2024

@ccarouge @rkutteh Noting that there is potential for issue creep here - could we extend this to also ensure consistency in other areas? I'm particularly thinking ensure that lakes have 'soil' properties consistent with water and zero-vegetation.

@ccarouge
Copy link
Collaborator

@rkutteh Why do we need this issue? Isn't is a duplicate of #280?

@rkutteh
Copy link
Collaborator Author

rkutteh commented Jul 16, 2024

@ccarouge please feel free to close #280 as the present issue is the one connected with my branch 338-consistency_ice_veg_soil and the benchcab testing I am doing now, and it supersedes #280

@rkutteh rkutteh linked a pull request Jul 16, 2024 that will close this issue
@ccarouge
Copy link
Collaborator

I'd rather not close #280 until it is fixed since it is the issue with all the discussions in. So I've connected to pull request to both issues and both will be closed once the pull request is merged.

In the future, please try not to duplicate issues. In this case, you should have linked the branch to the existing issue (create it from the existing issue page for example) instead of creating this issue to create (?) the branch afterwards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority:high High priority issues that should be included in the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants