Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor the specializations in binary_data_conversion class to use boost::hana #167

Open
gopi487krishna opened this issue Oct 11, 2020 · 0 comments
Labels
good first issue Good for newcomers

Comments

@gopi487krishna
Copy link
Collaborator

gopi487krishna commented Oct 11, 2020

A quick look at the binary_data_converter reveals massive chunk of specializations used for parsing different variants of binary data. This was done in order to increase performance while parsing binary table data ( In fact doing this helped us in making the binary data parser fastest among all the HDU table data parsers)

Now that we can use C++14, a compile time switch ( one given here -- real world example section ) can be used for removing the specialization and confining the code to one or two member functions .

This can help us in reducing that chunky code and make maintenance a lot easier!!! 😁

File : https://github.com/BoostGSoC19/astronomy/blob/develop/include/boost/astronomy/io/binary_data_converter.hpp

@gopi487krishna gopi487krishna added the good first issue Good for newcomers label Oct 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant