Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error margin in the metrics output / exporter #557

Open
damienfernandes opened this issue Jul 4, 2024 · 3 comments
Open

Add Error margin in the metrics output / exporter #557

damienfernandes opened this issue Jul 4, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@damienfernandes
Copy link
Contributor

Problem

In prometheus, we don't scrape error margin for collected impacts values.

Solution

To be able to explicit result, I will be interesting to add error margin and be able to display it in grafana.
Absolut Unvertainty will be calculated with rawdata bloc (min, max, value) for every impacts

Alternatives

Investigate if we add new metrics or we change value metrics to scrape Value ± Absolute Uncertainty

Additional context or elements

Absolute Uncertainty

@damienfernandes
Copy link
Contributor Author

@demeringo To provide scientific rigor when presenting experimental results 🧪

@demeringo
Copy link
Collaborator

demeringo commented Jul 4, 2024

I fully agree that returning the uncertaincy is important.

I think we need to do 3 things:

  • update the internal data model to add an uncertaincy field to each value.
  • create an xxx_absolute_uncertaincy metric for each existing `xxx metric (except maybe for the exact counters like number of instance etc...)
  • ... then calculate this uncertaincy using min and max values returned by API

@demeringo demeringo added the enhancement New feature or request label Jul 4, 2024
@demeringo
Copy link
Collaborator

demeringo commented Jul 11, 2024

@damienfernandes I realize that this issue, seems realy related to cloud scanner (not strickly boavizta API which already returns uncertaincy figures).

Do you agree ? I yes I can transfer the issue to cloud-scanner repository.

@demeringo demeringo transferred this issue from Boavizta/boaviztapi Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants