Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next Release Checklist (v1.14.0) #2782

Open
28 of 36 tasks
zlshames opened this issue Aug 10, 2024 · 2 comments
Open
28 of 36 tasks

Next Release Checklist (v1.14.0) #2782

zlshames opened this issue Aug 10, 2024 · 2 comments

Comments

@zlshames
Copy link
Member

zlshames commented Aug 10, 2024 •
edited by jjoelj
Loading

Bug fix Checklist

  • remove flutter foreground task dep
  • remove chat controller created log as it's kinda just extra and crowds the logs
  • fix empty notification issue
  • add ability to change log level via troubleshooting settings, default to high level to prevent read write lag
  • when receiving a zip file attachment, you can't open it. Tapping it does nothing. When long press -> save, we get a permission denied error.
    • we might need to prompt for the permission
  • fix invalid double when reading URL preview payload data

This error seems like it's because the we are trying to read the size of the URL preview as a string, but for some reason it's already a Size object. This is the payload data when the parsing fails:

BlueBubblesApp] {size: Instance of 'Size', URL: {NS.relative: https://photos.zillowstatic.com/fp/deb5f3a7af2406119d54dbdcb7150f3b-cc_ft_1536.jpg}}

[SyncManager] Incremental Sync Error: AsyncExecutorError: AsyncTask execution error
│ -- Cause: FormatException: Invalid double
│ 
│ #0      double.parse (dart:core-patch/double_patch.dart:113)
│ #1      new MediaMetadata.fromJson (package:bluebubbles/models/global/payload_data.dart:116)
│ #2      new UrlPreviewData.fromJson (package:bluebubbles/models/global/payload_data.dart:78)
│ #3      new PayloadData.fromJson.<anonymous closure> (package:bluebubbles/models/global/payload_data.dart:20)
│ #4      MappedIterable.elementAt (dart:_internal/iterable.dart:385)
│ #5      ListIterator.moveNext (dart:_internal/iterable.dart:354)
│ #6      new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189)
│ #7      new _GrowableList.of (dart:core-patch/growable_array.dart:150)
│ #8      new List.of (dart:core-patch/array_patch.dart:39)
│ #9      ListIterable.toList (dart:_internal/iterable.dart:224)
│ #10     new PayloadData.fromJson (package:bluebubbles/models/global/payload_data.dart:20)
│ #11     Message.dbPayloadData= (package:bluebubbles/models/io/message.dart:304)
│ #12     getObjectBoxModel.<anonymous closure> (package:bluebubbles/objectbox.g.dart:1580)
│ #13     EntityDefinition.objectFromData (package:objectbox/src/modelinfo/entity_definition.dart:43)
│ #14     CursorHelper._deserializeObject (package:objectbox/src/native/bindings/helpers.dart:128)
│ #15     CursorHelper.get (package:objectbox/src/native/bindings/helpers.dart:137)
│ #16     Box.get.<anonymous closure> (package:objectbox/src/native/box.dart:350)
│ #17     Store._runInTransaction (package:objectbox/src/native/store.dart:776)
│ #18     InternalStoreAccess.runInTransaction (package:objectbox/src/native/store.dart:894)
│ #19     Box.get (package:objectbox/src/native/box.dart:349)
│ #20     ToOne.target (package:objectbox/src/relations/to_one.dart:84)
│ #21     Attachment.merge (package:bluebubbles/models/io/attachment.dart:263)
│ #22     syncAttachments (package:bluebubbles/helpers/backend/sync/sync_helpers.dart:119)
│ #23     BulkSyncMessages.run.<anonymous closure> (package:bluebubbles/services/backend/sync/tasks/sync_tasks.dart:176)
│ #24     Store.runInTransaction.<anonymous closure> (package:objectbox/src/native/store.dart:628)
│ #25     Store._runInTransaction (package:objectbox/src/native/store.dart:776)
│ #26     Store.runInTransaction (package:objectbox/src/native/store.dart:628)
│ #27     BulkSyncMessages.run (package:bluebubbles/services/backend/sync/tasks/sync_tasks.dart:135)
  • fix invalid double when matching chats to messages in the sync Messages async task
│ [SyncManager] Incremental Sync Error: AsyncExecutorError: AsyncTask execution error
│ -- Cause: FormatException: Invalid double
│ 
│ #0      ObjectVisitorError.throwIfError (package:objectbox/src/native/bindings/data_visitor.dart:58)
│ #1      Query.find (package:objectbox/src/native/query/query.dart:1080)
│ #2      syncMessages (package:bluebubbles/helpers/backend/sync/sync_helpers.dart:174)
│ #3      BulkSyncMessages.run.<anonymous closure> (package:bluebubbles/services/backend/sync/tasks/sync_tasks.dart:183)
  • fix chat creator render issue causing participant list to be empty. The following error no longer occurs, but we should fix the underlying issue
  • fix back gesture issue when entering chat via notification
BlueBubblesApp] Stacktrace: #0      List.first (dart:core-patch/growable_array.dart:344)
│ #1      ChatCreatorState.build.<anonymous closure>.<anonymous closure> (package:bluebubbles/app/layouts/chat_creator/chat_creator.dart:598)
│ #2      SliverChildBuilderDelegate.build (package:flutter/src/widgets/scroll_delegate.dart:490)
│ #3      SliverMultiBoxAdaptorElement._build (package:flutter/src/widgets/sliver.dart:938)
│ #4      SliverMultiBoxAdaptorElement.performRebuild.processElement (package:flutter/src/widgets/sliver.dart:868)
  • Fix Emoji fill into focused text box #2777
  • Fix enabling spellcheck causes issues with the colon emoji picker
  • when sending an image, sometimes the notification in the chat list will say "Attachments: 2"
  • option to hide names from reactions/edits/unsends in notifications
  • "Leave a Review" should either hide or link to the relevant stores on desktop
  • fix deprecated theming schemes
  • fix scrolling on context menu re-ordering page
  • fix replies from notifications not showing properly
  • fix dupe notifications
  • implement copperboys fix: https://discord.com/channels/640229510662455326/781023536168304641/1275973402850754624
  • add warning when connecting if the entered server URL doesn't match firebase
  • Attempting to save live photo crashes Android app and saves an invalid file.
  • Progress amount and percentage is not correct when downloading live photos
  • digital touch messages don't show
  • iOS style 3 dot menu for iOS style
  • mentions default to just first name (or nickname if available)
  • completing editing a message in tablet mode closes the chat and not the edit popup
  • re-increase bubble darkening to .2 from .1
  • fix run away engine processed
  • If a message fails to send, and is retried in tablet mode, the message doesn't show in message view until back out/reenter
  • Make esc key close emoji picker desktop
  • Fix message options order only works for ios skin, not samsung or material #2808

Testing Checklist

  • test new background service (without FCM)
  • test new live logging and logging export capabilities
    • make sure no additional jank/lag is introduce
  • test message context menu re-ordering
  • black video preview bug
  • test live photo downloading on Android
@zlshames
Copy link
Member Author

I believe both invalid double errors were caused by the same "bad code". The one for the.find() call I think was the same error, but the stack trace was just concatenated maybe...

@zlshames
Copy link
Member Author

cant seem to fix the back gesture causing the app to exit when opening via a notification. Might be a flutter bug, or we are doing something wrong. However, the Back Button Interceptor package had the same issue as using PopScope. Basically, the pop callback isnt being called, no matter what i try. It's not logging anything, even in the dispose function...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zlshames