Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add multiple options to RollupFilter #592

Open
wants to merge 6 commits into
base: perf/leverage-stats-tables
Choose a base branch
from

Conversation

xFJA
Copy link
Collaborator

@xFJA xFJA commented Oct 12, 2024

Checklist

  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

THIS PR BUILDS ON TOP OF #590

The RollupFilter is able to select multiple rollups. Some changes have been required:

  • The Dropdown component has a new prop multiple that enables the multiple selection
  • The from query param passed to the withFilters in the API has been refactored to a string joined by , of all from addresses associated to the rollups selected
  • Created useOverflow hook to detect the overflow in the RollupFilter by applying an opacity linear gradient at the right end
  • Add new optional prop to Option type in Dropdown to be able to customize the component used for the option displayed in the input

Related Issue

Closes #545

Screenshots

Screen.Recording.2024-10-12.at.20.mp4

@xFJA xFJA self-assigned this Oct 12, 2024
Copy link

changeset-bot bot commented Oct 12, 2024

🦋 Changeset detected

Latest commit: a6796f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@blobscan/web Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
blobscan-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 13, 2024 10:37am
5 Skipped Deployments
Name Status Preview Comments Updated (UTC)
blobscan-docs ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 10:37am
blobscan-gnosis ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 10:37am
blobscan-holesky ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 10:37am
blobscan-mainnet ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 10:37am
blobscan-sepolia ⬜️ Ignored (Inspect) Visit Preview Oct 13, 2024 10:37am

Copy link

codecov bot commented Oct 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.43%. Comparing base (f3ade4b) to head (a6796f2).

Additional details and impacted files
@@                      Coverage Diff                       @@
##           perf/leverage-stats-tables     #592      +/-   ##
==============================================================
- Coverage                       89.46%   89.43%   -0.03%     
==============================================================
  Files                             154      154              
  Lines                           10302    10302              
  Branches                         1169     1169              
==============================================================
- Hits                             9217     9214       -3     
- Misses                           1085     1088       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Oct 12, 2024

📦 Next.js Bundle Analysis for @blobscan/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 283.89 KB (🟡 +38.27 KB)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

New Pages Added

The following pages were added to the bundle from the code in this PR:

Page Size (compressed) First Load % of Budget (350 KB)
/block_neighbor 251 B 284.13 KB 81.18%
/stats 347.9 KB 631.79 KB 180.51%

Eight Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/ 351.89 KB 635.78 KB 181.65% (🟢 -4.98%)
/address/[address] 27.36 KB 311.25 KB 88.93% (🟢 -4.68%)
/blob/[hash] 28.04 KB 311.92 KB 89.12% (🟢 -4.11%)
/blobs 77.64 KB 361.53 KB 103.29% (🟡 +12.81%)
/block/[id] 13.76 KB 297.64 KB 85.04% (🟢 -4.32%)
/blocks 75.34 KB 359.23 KB 102.64% (🟡 +12.79%)
/tx/[hash] 15.71 KB 299.6 KB 85.60% (🟡 +0.70%)
/txs 74.84 KB 358.73 KB 102.49% (🟡 +10.79%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@xFJA xFJA marked this pull request as draft October 13, 2024 09:09
@xFJA xFJA marked this pull request as ready for review October 13, 2024 10:34
@xFJA xFJA changed the base branch from main to perf/leverage-stats-tables October 13, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to select multiple rollups when filtering elements
1 participant