Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a grid for icons #40

Closed
GBKS opened this issue Apr 7, 2021 · 4 comments
Closed

Implement a grid for icons #40

GBKS opened this issue Apr 7, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@GBKS
Copy link
Collaborator

GBKS commented Apr 7, 2021

Having a basic grid template would help us create more consistency across icons. Below is an example. The grid has a few preset sizes an icon may use (but doesn't have to).

Bitcoin icon set grids 210407

A good next step could be to take a few representative icons and adjust them to the grids, to see whether this is easy to work with and actually does lead to more consistency.

One part of this is also to snap values to full pixels. In a time of retina screens and vector-rendering, this is not 100% necessary, but generally sticking with it should also help the icon set look consistent.

@GBKS GBKS self-assigned this Apr 7, 2021
@GBKS
Copy link
Collaborator Author

GBKS commented Apr 12, 2021

Some more references for design guidelines:

@Bosch-0
Copy link
Collaborator

Bosch-0 commented Apr 19, 2021

Started working on this in the Figma file. Will be finished in a few days. I've added a grid underlay you can toggle on/off for each icon in the left hand assets menu.

Was also thinking of adding an SVG of the grids in the repo so designers can easily download and use it in whatever vector tool they are using. @GBKS thoughts? Or would it be best to keep this repo purely for the icons.

@GBKS
Copy link
Collaborator Author

GBKS commented Apr 19, 2021

Sounds good to me. The SVG could go in the "img" folder, and would also allow us to reference it in the Readme, to document the grid logic.

@GBKS GBKS added the enhancement New feature or request label Apr 26, 2021
@GBKS
Copy link
Collaborator Author

GBKS commented Apr 26, 2021

This is implemented now with the latest commit.

Thanks @Bosch-0 for the hardcore work on this. It was super tedious. But now the icons are way more consistent and we have a better system in place for design iteration.

@GBKS GBKS closed this as completed Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants