Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hash management in URL #209

Open
fbastian opened this issue May 26, 2020 · 1 comment
Open

Fix hash management in URL #209

fbastian opened this issue May 26, 2020 · 1 comment

Comments

@fbastian
Copy link
Member

In GitLab by @fbastian on Feb 13, 2019, 17:51

The permalink copied to clipboard does not take into account the hash fragment of the URL. This fragment i not sent to the server by clients, so it has to be managed in js. It's important notably for TopAnat, without the hash, the permalink is useless.

Also, fix tests in RequestParametersTest using TEST_STABLE_ROOT_DIR, there's a problem when we need to manage the hash part with the method getStableRequestURL. Maybe this highlights a wider design issue with the method signatures in RequestParameters class.

@fbastian
Copy link
Member Author

In GitLab by @fbastian on Feb 13, 2019, 17:52

changed the description

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant