Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SoapClientBuilder options #102

Open
steve-ii opened this issue Sep 29, 2015 · 1 comment
Open

SoapClientBuilder options #102

steve-ii opened this issue Sep 29, 2015 · 1 comment

Comments

@steve-ii
Copy link

Hi guys,
Just noticed that there is a little mistake in the SoapClientBuilder class.
When adding Attachments, the code uses $this->options instead of $this->soapOptions.

public function withBase64Attachments()
{
    $this->options['attachment_type'] = Helper::ATTACHMENTS_TYPE_BASE64;

    return $this;
}

/**
 * SOAP attachment type SwA.
 *
 * @return \BeSimple\SoapServer\SoapServerBuilder
 */
public function withSwaAttachments()
{
    $this->options['attachment_type'] = Helper::ATTACHMENTS_TYPE_SWA;

    return $this;
}

/**
 * SOAP attachment type MTOM.
 *
 * @return \BeSimple\SoapServer\SoapServerBuilder
 */
public function withMtomAttachments()
{
    $this->options['attachment_type'] = Helper::ATTACHMENTS_TYPE_MTOM;

    return $this;
}

Need to be replaced by :

public function withBase64Attachments()
{
    $this->soapOptions['attachment_type'] = Helper::ATTACHMENTS_TYPE_BASE64;

    return $this;
}

/**
 * SOAP attachment type SwA.
 *
 * @return \BeSimple\SoapServer\SoapServerBuilder
 */
public function withSwaAttachments()
{
    $this->soapOptions['attachment_type'] = Helper::ATTACHMENTS_TYPE_SWA;

    return $this;
}

/**
 * SOAP attachment type MTOM.
 *
 * @return \BeSimple\SoapServer\SoapServerBuilder
 */
public function withMtomAttachments()
{
    $this->soapOptions['attachment_type'] = Helper::ATTACHMENTS_TYPE_MTOM;

    return $this;
}

Cheers !

@minimihi
Copy link

minimihi commented Oct 5, 2015

Pull request: BeSimple/BeSimpleSoap#71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants